-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add tab completion to the chat / command box #2677
Comments
We will do this after the UI/UX redesign to avoid duplicating work |
@fernzharp will tackle this this week and start building a Figma library for Hubs chat styles. |
Tagging @mbransn as an FYI |
@malqinneh @fernzharp the best jumping off point for chat style creation will be this file. Planning that this file should evolve to become the working Hubs Figma Library as it's what the ongoing UI implementation is based on. :) |
Hi all, |
That looks great to me! |
@fernzharp great start Dan! What would this look like if the chat was populated all the way through (and the tab completion box overlapped the grey chat bubbles?) Also, how did you manage to get the chat drawer to show up? I was under the impression that the way chat works on Hubs is via the chat input on the centre-bottom of the screen: |
@malqinneh Dan is working from the UI updates that are current undergoing implementation. This file is the basis and implementation progress is on storybook here. We're working to solve this as part of that UI update roll out. 😀 @fernzharp can you make an alt. version where the command menu has a white background and a drop shadow? This may better distinguish the command menu from a chat message as the chat becomes full. (perhaps best to mock both an empty chat background and a full chat background.) Additionally how about leaning into the blue color as 'action' and utilize it on the cursor selector hover state? Also in the future if you land a link with your screenshot/comment I'm happy to leave feedback there, may be easier to parse? Thanks for thinking this through! |
I understand - thank you for clarifying! |
Hello all! https://www.figma.com/file/gEGSKPmcDaeQ7v1s8QZ0DE/Hubs-Redesign-(Copy)?node-id=108%3A9290 |
Update: Hi! https://drive.google.com/file/d/1bCQ1cE7xkmWro7qbOksh49HjvCV1NeRN/view?usp=sharing |
Thanks @fernzharp, this update came together well! Looks ready to me, @misslivirose @robertlong shout if you have questions. |
Proposed project plan
Goal
There is an opportunity here to add usability to the command list suggestions.
The goal is to be able to select these suggestions through tab key/arrow keys or a mouse click.
This will be prototyped to fit with the Hubs UI redesign currently underway.
Subtasks
List all action items or subtasks to accomplish the above goal.
Revise prototype based on feedback from DPX-XD team.
Add vertical scroll bar to scroll modal.
Increase command list padding.
Page(s) showing different states of form elements.
Timeline and priority
Rough timeline based on a 5-day sprint.
Linked issues (if applicable)
Please list any other GitHub issues that are constrained by or dependent on this feature here.
Additional context
when I type /audio it has a popup which shows that /audiomode is an option. If I press the tab key or arrow keys I should be able to select /audiomode without typing the whole thing.
The text was updated successfully, but these errors were encountered: