Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Specify the dependencies in package.json #317

Closed
Iinh opened this issue Jan 14, 2021 · 1 comment
Closed

Specify the dependencies in package.json #317

Iinh opened this issue Jan 14, 2021 · 1 comment
Labels
dependencies Pull requests that update a dependency file good first issue Good for newcomers
Milestone
Backlog

Comments

@Iinh
Copy link
Contributor

Iinh commented Jan 14, 2021

#312 (comment)

We should reorganize package.json and specify what packages needed for production ("dependencies") versus local development ("devDependencies").
@Iinh Iinh added good first issue Good for newcomers dependencies Pull requests that update a dependency file labels Jan 14, 2021
@wlach wlach added this to the Phase 1.1 - MVP follow-ons milestone Jan 15, 2021
@wlach
Copy link
Contributor

wlach commented Jan 15, 2021

I think for a webapp like this the distinction between devDependencies and dependencies is not so important -- we're not publishing it to npm or anything. That said, it makes sense to be consistent. In this case, I think technically everything should just be a devDependency.

@Iinh Iinh closed this as completed in c6ef35b Jul 23, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
dependencies Pull requests that update a dependency file good first issue Good for newcomers
Projects
None yet
Milestone
Backlog
Development

No branches or pull requests
2 participants
@wlach @Iinh