Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make sure generated references metadata isn't overriden by static metadata #4618

Open
whd opened this issue Nov 28, 2023 · 0 comments
Open

Comments

@whd
Copy link
Member

whd commented Nov 28, 2023

https://github.com/mozilla/bigquery-etl/pull/4613/files#r1408290814

I could be misinterpreting what's happening here but it seems like specifying references: {} explicitly in main branch metadata may sometimes cause references to not be correctly generated/overridden in generated metadata. I'm not aware of any case where we'd want an empty static value for references to be preferred to a generated value, but there may be complex generated cases where some non-empty value should be preferred.

Another option might be to in CI enforce not setting references at all and require it be generated.

┆Issue is synchronized with this Jira Task

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant