Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Explore progressive enhancement of /all for a11y #15293

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

robhudson
Copy link
Member

One-line summary

This is an exploration in using progressive enhancement to load only the changed content to improve the a11y issues brought up in the Github issue.

This is an htmx-like approach to rendering only the partial HTML content rather than the full page and using innerHTML to write the partial content in place. This seems to work well for me locally but I'm not sure if this solves the a11y issues.

  • I used an AI to write some of this code.

Significant changes and points to review

I'm interested if these changes help alleviate this specific issue:

However, when a user selects an item, the page reloads and doesn't automatically take a screen reader user to the next selection, forcing them to go through the page from the beginning.

Issue / Bugzilla link

#15082

Testing

Copy link

codecov bot commented Oct 14, 2024

Codecov Report

Attention: Patch coverage is 66.66667% with 1 line in your changes missing coverage. Please review.

Project coverage is 78.40%. Comparing base (eac0cbf) to head (f0feb95).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
bedrock/firefox/views.py 66.66% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main   #15293      +/-   ##
==========================================
- Coverage   78.40%   78.40%   -0.01%     
==========================================
  Files         157      157              
  Lines        8170     8172       +2     
==========================================
+ Hits         6406     6407       +1     
- Misses       1764     1765       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@robhudson
Copy link
Member Author

@reemhamz Would you be willing to look at this locally with your screen reader to see if it helps at all?

@reemhamz
Copy link
Contributor

Just tested it, and unfortunately it's still disrupting the user flow as it was prior :/ were you able to test it using a screenreader? If so, did it produce different results on your end?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants