Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Swift FxAccountDeviceConstellation should notify when push endpoint is expired #3199

Closed
rfk opened this issue Jun 4, 2020 · 6 comments · Fixed by mozilla-mobile/firefox-ios#6851
Assignees

Comments

@rfk
Copy link
Contributor

rfk commented Jun 4, 2020

The swift FxAccountDeviceConstellation currently logs and ignores the "your push endpoint has expired" flag set on its device record by the FxA server. It's important that the application be able to recovery from this state, otherwise send-tab will not work correctly.

@eoger what do you think about firing a notification event when we discover this, to allow the app to handle it?

As a first step, perhaps we can have the app log an error to sentry or submit telemetry when it receives this notification.

┆Issue is synchronized with this Jira Task
┆Epic: Trusted Send Tab Telemetry
┆Sprint: SYNC - end 2020-07-03

@eoger
Copy link
Contributor

eoger commented Jun 4, 2020

Yes I think it is a good idea, do we know how often we get a pushEndpointExpired on iOS in practice though?

@lougeniaC64
Copy link
Contributor

@eoger @rfk Assuming this should stay in the backlog in the send tab epic?

@rfk
Copy link
Contributor Author

rfk commented Jun 4, 2020

Assuming this should stay in the backlog in the send tab epic?

Yep, sounds good.

@mhammond
Copy link
Member

mhammond commented Jun 5, 2020

Yes I think it is a good idea, do we know how often we get a pushEndpointExpired on iOS in practice though?

I had the same question for desktop and Ryan said that, basically, it should never expire - except when it does :) We don't know what the mean time is for expiry, but there's no "expected" time.

@eoger
Copy link
Contributor

eoger commented Jun 23, 2020

We settled on: "let's log an error on Sentry"

@eoger
Copy link
Contributor

eoger commented Jun 24, 2020

We settled on: "let's log an error on Sentry"

I ended up just re-registering when we see the flag, it was fairly easy actually.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants