Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix the lint issues required to upgrade to eslint-config-airbnb 11 #9842

Closed
muffinresearch opened this issue Sep 8, 2016 · 3 comments
Closed

Fix the lint issues required to upgrade to eslint-config-airbnb 11 #9842

muffinresearch opened this issue Sep 8, 2016 · 3 comments
Assignees
@kumar303
Labels
repository:addons-frontend Issue relating to addons-frontend

Comments

@muffinresearch
Copy link
Contributor

muffinresearch commented Sep 8, 2016 •
edited
Loading

Looks like there's a lot of updated incoming rules we're going to need to fix to pass lint.

See https://travis-ci.org/mozilla/addons-frontend/jobs/158381739 via mozilla/addons-frontend#1042
@kumar303 kumar303 self-assigned this Sep 8, 2016
@kumar303
Copy link
Contributor

kumar303 commented Sep 9, 2016

Running into jsx-eslint/eslint-plugin-react#816 but I can work around it.

@kumar303
Copy link
Contributor

kumar303 commented Sep 9, 2016

It also looks like we can't reuse PropType definitions: jsx-eslint/eslint-plugin-react#817

@muffinresearch
Copy link
Contributor Author

Fixed by mozilla/addons-frontend#1042

@KevinMind KevinMind transferred this issue from mozilla/addons-frontend May 5, 2024
@KevinMind KevinMind added repository:addons-frontend Issue relating to addons-frontend migration:2024 labels May 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@kumar303 kumar303

Labels
repository:addons-frontend Issue relating to addons-frontend
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@muffinresearch @kumar303 @addons-robot @KevinMind