Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: frontend pages display the restricted/blocked page for available versions #15126

Open
1 task done
ioanarusiczki opened this issue Oct 30, 2024 · 1 comment
Open
1 task done

Comments

@ioanarusiczki
Copy link

ioanarusiczki commented Oct 30, 2024

What happened?

followup #15013

An addon with multiple versions has 2 versions restricted and one is still approved and available.
https://reviewers.addons-dev.allizom.org/en-US/reviewers/review/633708

The frontend urls with versions specified displays for the approved version 3.0 that it's been restricted
https://addons-dev.allizom.org/en-US/firefox/blocked-addon/%7Bf2fe1fd3-5ad6-45ed-863d-0abfabae74ad%7D/3.0/

(replacing 3.0 with any other version even one that doesn't exist https://addons-dev.allizom.org/en-US/firefox/blocked-addon/%7Bf2fe1fd3-5ad6-45ed-863d-0abfabae74ad%7D/17.0/, it would show the restricted page for this guid)

with no version specified https://addons-dev.allizom.org/en-US/firefox/blocked-addon/%7Bf2fe1fd3-5ad6-45ed-863d-0abfabae74ad%7D/ also shows the restricted page

What did you expect to happen?

a 404 because the specified version does not have a restriction/block

Is there an existing issue for this?

  • I have searched the existing issues

┆Issue is synchronized with this Jira Task

@willdurand
Copy link
Member

with no version specified addons-dev.allizom.org/en-US/firefox/blocked-addon/%7Bf2fe1fd3-5ad6-45ed-863d-0abfabae74ad%7D also shows the restricted page

that's kinda expected at least

For the two other URLs, we've largely ignored the version in the URL in the past. That said, I think it'd be fine to return a 404 when the version isn't blocked now that we do something useful with the version in the URL.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants