Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Unwrap HOC components to make shallow render tests more effective #10515

Closed
kumar303 opened this issue Jun 27, 2017 · 1 comment · Fixed by mozilla/addons-frontend#2926
Closed

Unwrap HOC components to make shallow render tests more effective #10515

kumar303 opened this issue Jun 27, 2017 · 1 comment · Fixed by mozilla/addons-frontend#2926
Assignees
@kumar303
Labels
qa:not_needed repository:addons-frontend Issue relating to addons-frontend
Milestone
2017.08.17

Comments

@kumar303
Copy link
Contributor

Since we use shallow Enzyme rendering now we no longer have to test the base (i.e. unwrapped) components. We should be able to introduce a helper that unwraps them automatically.

Example: mozilla/addons-frontend#2618 (comment)
@kumar303 kumar303 self-assigned this Jun 27, 2017
@kumar303 kumar303 mentioned this issue Jun 27, 2017
Merged
@kumar303
Copy link
Contributor Author

Enzyme doesn't have great support for doing this kind of unwrapping: enzymejs/enzyme#539

@kumar303 kumar303 mentioned this issue Aug 10, 2017
Merged
@KevinMind KevinMind transferred this issue from mozilla/addons-frontend May 5, 2024
@KevinMind KevinMind added repository:addons-frontend Issue relating to addons-frontend migration:2024 labels May 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@kumar303 kumar303

Labels
qa:not_needed repository:addons-frontend Issue relating to addons-frontend
Projects
None yet
Milestone
2017.08.17
Development

Successfully merging a pull request may close this issue.

Make it possible to test default component instances (with helper function) kumar303/addons-frontend
3 participants
@kumar303 @addons-robot @KevinMind