Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to EsLint v6 #2658

Closed
EnTeQuAk opened this issue Jun 26, 2019 · 3 comments
Closed

Update to EsLint v6 #2658

EnTeQuAk opened this issue Jun 26, 2019 · 3 comments

Comments

@EnTeQuAk
Copy link
Contributor

WIP PR: #2652

@EnTeQuAk EnTeQuAk self-assigned this Jun 26, 2019
@EnTeQuAk EnTeQuAk added this to the 2019.06.27 milestone Jun 26, 2019
@EnTeQuAk EnTeQuAk modified the milestones: 2019.06.27, 2019.07.04 Jun 26, 2019
@EnTeQuAk EnTeQuAk modified the milestones: 2019.07.04, 2019.07.18 Jul 11, 2019
@EnTeQuAk EnTeQuAk modified the milestones: 2019.07.18, 2019.07.25 Jul 18, 2019
@EnTeQuAk EnTeQuAk added this to the 2020.01.30 milestone Jan 15, 2020
@diox diox modified the milestones: 2020.02.06, 2020.02.13 Feb 10, 2020
@EnTeQuAk EnTeQuAk removed this from the 2020.02.13 milestone Feb 12, 2020
@EnTeQuAk EnTeQuAk added this to the 2020.03.12 milestone Mar 4, 2020
@eight04
Copy link

eight04 commented Mar 7, 2020

I got some reports from npm audit:

                       === npm audit security report ===


                                 Manual Review
             Some vulnerabilities require your attention to resolve

          Visit https://go.npm.me/audit-guide for additional guidance


  Moderate        Regular Expression Denial of Service

  Package         acorn

  Patched in      >=7.1.1

  Dependency of   web-ext [dev]

  Path            web-ext > addons-linter > eslint > espree > acorn

  More info       https://npmjs.com/advisories/1488


  Moderate        Regular Expression Denial of Service

  Package         acorn

  Patched in      >=7.1.1

  Dependency of   web-ext [dev]

  Path            web-ext > addons-linter > eslint-plugin-no-unsafe-innerhtml
                  > eslint > espree > acorn

  More info       https://npmjs.com/advisories/1488

found 2 moderate severity vulnerabilities in 4008 scanned packages
  2 vulnerabilities require manual review. See the full report for details.

Does upgrading eslint solve the problem?

@EnTeQuAk EnTeQuAk removed this from the 2020.03.12 milestone Mar 11, 2020
@EnTeQuAk EnTeQuAk removed their assignment May 11, 2020
@EnTeQuAk
Copy link
Contributor Author

@rpl @willdurand I'm not able to finish this off. I don't think it's urgent but unfortunately it has been sitting around for a long time. On the other hand, from what I figured with playing around and wasting lots of time in the PR is that the eslint APIs have changed significantly again and especially mocking has become harder. I hope the work in the PR is useful.

@willdurand willdurand self-assigned this May 11, 2020
@willdurand
Copy link
Member

done.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants
@EnTeQuAk @diox @willdurand @eight04 and others