Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Try to get more code coverage for PerformanceObserver #1463

Open
bobsilverberg opened this issue Feb 27, 2020 · 0 comments
Open

Try to get more code coverage for PerformanceObserver #1463

bobsilverberg opened this issue Feb 27, 2020 · 0 comments
Assignees
@bobsilverberg
Labels
component:code_quality component:testing priority:p3

Comments

@bobsilverberg
Copy link
Contributor

bobsilverberg commented Feb 27, 2020 •
edited by data-sync-user
Loading

This is a follow-up to #1454, which introduced a PerformanceObserver into the App component. I was unable to figure out how to get code coverage for the body of the callback that is defined when we create the new PerformanceObserver, but I intend to continue looking into this and hopefully will be able to figure it out and fix the coverage that is missing according to https://codecov.io/gh/mozilla/addons-code-manager/pull/1454/diff.

┆Issue is synchronized with this Jira Task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@bobsilverberg bobsilverberg

Labels
component:code_quality component:testing priority:p3
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

More mocking for PerformanceObserver bobsilverberg/addons-code-manager
1 participant
@bobsilverberg