From 96567905e7650cf24fd595602b4df020588c57ee Mon Sep 17 00:00:00 2001 From: JR Conlin Date: Thu, 18 Mar 2021 17:58:37 -0700 Subject: [PATCH] doc: Add reminders to notify iOS team on changing limits (#1028) Closes #1026 --- spanner_config.ini | 6 ++++++ src/db/spanner/BATCH_COMMIT.txt | 9 +++++++++ 2 files changed, 15 insertions(+) diff --git a/spanner_config.ini b/spanner_config.ini index 9f0015cc17..5fb0cc05ae 100644 --- a/spanner_config.ini +++ b/spanner_config.ini @@ -1,2 +1,8 @@ # Limit the number of incoming records (See issue #298/#333/#869) +# NOTE: Make sure to alert the iOS team after altering any of these values +# in production +# * limits.MAX_REQUEST_BYTES +# * limits.MAX_POST_REQCORDS +# * limits.MAX_TOTAL_RECORDS +# * limits.MAX_TOTAL_BYTES limits.max_total_records=1664 diff --git a/src/db/spanner/BATCH_COMMIT.txt b/src/db/spanner/BATCH_COMMIT.txt index 91d1dffc2c..70bd919adb 100644 --- a/src/db/spanner/BATCH_COMMIT.txt +++ b/src/db/spanner/BATCH_COMMIT.txt @@ -56,3 +56,12 @@ Totals: - quota: True 6 + 19968 + 1 + 6 = 19981 + + +**NOTE** iOS hardcodes syncstorage values. ANY ALTERATION OF THE FOLLOWING VALUES +MUST REQUIRE FILING AN ISSUE WITH THE iOS TEAM! + +* MAX_REQUEST_BYTES +* MAX_POST_REQCORDS +* MAX_TOTAL_RECORDS +* MAX_TOTAL_BYTES \ No newline at end of file