Skip to content
This repository has been archived by the owner on Jan 17, 2023. It is now read-only.

Strange selection behaviour when "inverting" selection size. #1630

Closed
flukeout opened this issue Sep 29, 2016 · 5 comments
Closed

Strange selection behaviour when "inverting" selection size. #1630

flukeout opened this issue Sep 29, 2016 · 5 comments
Assignees
Milestone

Comments

@flukeout
Copy link

seleciton-lop

This looks weird. If I drag from the bottom right past the top left, can we just invert the selection so the top-left corner becomes the bottom-right and I continue drawing my box? That would be the standard behaviour.

@ianb
Copy link
Contributor

ianb commented Sep 29, 2016

Yes, this is the behavior I intentionally implemented when fixing the problem of a selection collapsing to no height or width. The inverted selection is common, but I couldn't come up with a reason for it (outside of algorithmic simplicity). Instead this is intended as a way to kind of bump the selection.

@flukeout
Copy link
Author

With the current behaviour, it's doubtful that I'll get the top-left corner to end up exactly where I want it after one of the 'bumps' so I'll end up having adjusting it anyway - not sure it saves much time.

@johngruen
Copy link
Contributor

@ianb i've had a few people mention this to me on slack. i think inverting the selection is the expected behavior here.

@johngruen johngruen removed the needs:UX label Oct 5, 2016
@flukeout
Copy link
Author

flukeout commented Oct 5, 2016

+1 @johngruen - stick with expected behaviour unless the new way provides some special utility.

I could see the current way being useful as a reset for the top-left corner, but not in it's current "jumpy" implementation. If you were able to move the top left corner smoothly as you moved your mouse, that might be useful.

@ianb ianb added this to the Stretch milestone Oct 12, 2016
@ianb ianb self-assigned this Oct 13, 2016
@fzzzy fzzzy closed this as completed in ae47ad9 Oct 17, 2016
@ianb
Copy link
Contributor

ianb commented Nov 1, 2016

This change was released in the v1 release which went out on October 26th.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants