Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make form group collapsable #268

Closed
zengfenfei opened this issue Jul 7, 2016 · 8 comments
Closed

Make form group collapsable #268

zengfenfei opened this issue Jul 7, 2016 · 8 comments

Comments

@zengfenfei
Copy link

Since my schema has nested objects and is kind of large, it will be great help to collapse some of objects.

@n1k0
Copy link
Collaborator

n1k0 commented Jul 7, 2016

This is definitely something we want indeed.

@n1k0
Copy link
Collaborator

n1k0 commented Jul 11, 2016

As often, the hardest part is the UX here. I came with this for now as a programmatic PoC, but am wondering how the UI could expose something convenient and not intrusive. Thoughts?

@amarnus
Copy link
Contributor

amarnus commented Jul 11, 2016

I feel that it will be better to keep this functionality outside this module and instead support widgets for Array and Object fields in a better way so that people can build this functionality by themselves as a widget. Collapsing is just one option. You can also show as Tabs, for instance.

@n1k0
Copy link
Collaborator

n1k0 commented Jul 11, 2016

Very true, and this lib does a lot already so we shouldn't bloat it up with more core features most people won't ever need.

I'll look into #225 to see where we're at to have custom object and array widgets.

@n1k0
Copy link
Collaborator

n1k0 commented Jul 18, 2016

A field template system as described in #284 would indeed expose a convenient API to implement this. Let's do this.

@nuclearspike
Copy link

Being able to set a wrapping component of a fieldset would solve this. Then you could use tabs or collapsible sections, columns, or anything you wanted. I'd want to be able to define the wrapping component then an object that contains all the props to be passed to it (for tab titles, etc). I don't know that the field template system would be enough since isn't that only at the field level? Would we need a fieldset template?

@n1k0
Copy link
Collaborator

n1k0 commented Jul 20, 2016

Would we need a fieldset template?

Yeah this is a good idea, please comment on #284 about it.

@n1k0
Copy link
Collaborator

n1k0 commented Aug 19, 2016

Now #304 has landed we can safely close this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants