Skip to content
This repository has been archived by the owner on Jan 17, 2023. It is now read-only.

Use minimum size on click-to-select #1745

Closed
ianb opened this issue Oct 13, 2016 · 0 comments
Closed

Use minimum size on click-to-select #1745

ianb opened this issue Oct 13, 2016 · 0 comments
Assignees
Milestone

Comments

@ianb
Copy link
Contributor

ianb commented Oct 13, 2016

Right now we look for a reasonable block-level element, but we don't have a minimum size. I think this results in some disappointing results.

I am not sure what size to treat as the minimum.

There are also some elements that are maybe "better" than others, such as role=article on Facebook (which will get you one comment). It might be worth going to parentNodes to find such an element, so long as the element itself is not too large (e.g., takes up most of the screen).

I'm going to do this before (or with) #1633, as I have to revisit the way calculations are done for that issue anyway (precalculating these elements instead of on-demand).

@ianb ianb added this to the Altair milestone Oct 13, 2016
@ianb ianb self-assigned this Oct 13, 2016
@fzzzy fzzzy closed this as completed in d42b0a8 Oct 17, 2016
fzzzy added a commit that referenced this issue Oct 17, 2016
r?fzzzy Fix #1745, use a minimum size on the click autodetect
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant