Skip to content
This repository has been archived by the owner on Jan 27, 2022. It is now read-only.

Add unit tests #4

Open
sciurus opened this issue Jul 26, 2018 · 0 comments
Open

Add unit tests #4

sciurus opened this issue Jul 26, 2018 · 0 comments

Comments

@sciurus
Copy link
Contributor

sciurus commented Jul 26, 2018

  • incident_acknowledged_or_resolved needs tests to validate it handles input appropriately.
  • components_with_incidents needs stubbed get_acknowledged_incidents to test different scenarios around incidents with and without component tags
  • components_and_incidents needs stubbed get_incidents to test different scenarios around incidents we did and didn't create
  • open_incident and close_incident need mocked _created_incident and _update_incident to test they're calling them with the correct arguments (e.g. chose the right template and appended watermark)
  • sync needs stubbed components_with_incidents + components_and_incidents and mocked close_incident + open_incident to ensure the latter are called correctly for different combinations of statuspage and pagerduty incidents
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant