Skip to content
This repository has been archived by the owner on Jul 13, 2023. It is now read-only.

Move preflight check for webpush into validation.py #563

Closed
bbangert opened this issue Jul 28, 2016 · 3 comments
Closed

Move preflight check for webpush into validation.py #563

bbangert opened this issue Jul 28, 2016 · 3 comments
Labels
enhancement p3
Milestone
PUSHSVC-0: quality

Comments

@bbangert
Copy link
Member

bbangert commented Jul 28, 2016 •
edited
Loading

Once #492 is complete, then the preflight check from router/webpush.py should be moved into the WebPushRequest schema in validation.py.
@bbangert bbangert added this to the PUSHSVC-0: quality milestone Jul 28, 2016
@bbangert
Copy link
Member Author

Blocked on #492.

@jrconlin jrconlin added p2 p1 and removed p3 p2 labels Aug 8, 2016
@jrconlin jrconlin added p3 and removed p1 labels Aug 19, 2016
@jrconlin
Copy link
Member

crap, restoring because of blockage.

@pjenvey
Copy link
Member

pjenvey commented Jan 11, 2017

#765 was a duplicate of this -- now fixed as of PR #772

@pjenvey pjenvey closed this as completed Jan 11, 2017
@pjenvey pjenvey removed the blocked label Jan 11, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
enhancement p3
Projects
None yet
Milestone
PUSHSVC-0: quality
Development

No branches or pull requests
3 participants
@pjenvey @jrconlin @bbangert