Skip to content
This repository has been archived by the owner on Jul 13, 2023. It is now read-only.

Don't say the service is unavailable in errno 202 #377

Closed
bbangert opened this issue Feb 25, 2016 · 3 comments
Closed

Don't say the service is unavailable in errno 202 #377

bbangert opened this issue Feb 25, 2016 · 3 comments

Comments

@bbangert
Copy link
Member

During deploys, or even in normal operation when a user leaves, we don't clear the node until a message hits. For this, we return a 503 with errno 202. The error returned however says "Service Unavailable". That's quite false, the service is fine, the 503 is intentional and the request should be retried. We should not say the service is unavailable.

@bbangert bbangert added this to the PUSHSVC-0: quality milestone Feb 25, 2016
@bbangert bbangert added the ready label Feb 25, 2016
@jrconlin
Copy link
Member

jrconlin commented Mar 3, 2016

Hrm. the only place we return status=503, errno=202 is
https://github.com/mozilla-services/autopush/blob/master/autopush/router/simple.py#L110
which notes "Node was invalid", "Retry Request"

Was this bug fixed by another patch?

@bbangert
Copy link
Member Author

bbangert commented Mar 3, 2016

It's because a 503 has its error message copied into the JSON, and 503 has the raw text "Service Unavailable".

@bbangert
Copy link
Member Author

bbangert commented Mar 4, 2016

Dupe of #378, closed by #384.

@bbangert bbangert closed this as completed Mar 4, 2016
@bbangert bbangert removed the ready label Mar 4, 2016
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants