Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove the NotificationRecord struct #791

Open
data-sync-user opened this issue Oct 29, 2024 · 0 comments
Open

Remove the NotificationRecord struct #791

data-sync-user opened this issue Oct 29, 2024 · 0 comments
Labels
good first bug Good for newcomers

Comments

@data-sync-user
Copy link
Collaborator

data-sync-user commented Oct 29, 2024 •
edited
Loading

Really a followup to https://mozilla-hub.atlassian.net/browse/SYNC-3451

The NotificationRecord struct is really DynamoDB specific, representing the stored notification in DynamoDB w/ conversions between the higher level Notification struct.

So this struct should be removed entirely. However we still use its static method for parsing chidmessageids, which should be moved elsewhere (probably into RangeKey).

┆Issue is synchronized with this Jira Task
@jrconlin jrconlin added the good first bug Good for newcomers label Oct 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first bug Good for newcomers
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@jrconlin @data-sync-user