Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove the encryption_key/enckey fields #272

Open
pjenvey opened this issue Apr 1, 2021 · 0 comments
Open

Remove the encryption_key/enckey fields #272

pjenvey opened this issue Apr 1, 2021 · 0 comments
Labels
2 Estimate - Small cleanup Database garbage collection and other general clean up and cost reduction tasks.

Comments

@pjenvey
Copy link
Member

pjenvey commented Apr 1, 2021

Per #268 (review):

The encryption_key struct field and enckey entry in the router message data were only needed for aesgcm128 support which is no longer supported. We should remove these (and adjust the validation check against for it).

The various supported crypto encoding standards impls often need to be compared against each other and enc key is just now extra unnecessary noise, so this is a small but IMHO useful cleanup.
@pjenvey pjenvey added 2 Estimate - Small cleanup Database garbage collection and other general clean up and cost reduction tasks. labels Apr 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
2 Estimate - Small cleanup Database garbage collection and other general clean up and cost reduction tasks.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@pjenvey