bug: Add errors for health check reporting (#610)

(NOTE: This uses the `error!()` macro.)

autoconnect/autoconnect-web/src/dockerflow.rs

@@ -26,8 +26,19 @@ pub fn config(config: &mut web::ServiceConfig) {
 }
 
 /// Handle the `/health` and `/__heartbeat__` routes
+// note, this changes to `blocks_in_conditions` for 1.76+
+#[allow(clippy::blocks_in_if_conditions)]
 pub async fn health_route(state: Data<AppState>) -> Json<serde_json::Value> {
-    let status = if state.db.health_check().await.is_ok() {
+    let status = if state
+        .db
+        .health_check()
+        .await
+        .map_err(|e| {
+            error!("Autoconnect Health Error: {:?}", e);
+            e
+        })
+        .is_ok()
+    {
         "OK"
     } else {
         "ERROR"

autoendpoint/src/routes/health.rs

@@ -41,10 +41,13 @@ fn interpret_table_health(health: DbResult<bool>) -> serde_json::Value {
             "status": "NOT OK",
             "cause": "Nonexistent table"
         }),
-        Err(e) => json!({
-            "status": "NOT OK",
-            "cause": e.to_string()
-        }),
+        Err(e) => {
+            error!("Autoendpoint health error: {:?}", e);
+            json!({
+                "status": "NOT OK",
+                "cause": e.to_string()
+            })
+        }
     }
 }
 

autopush-common/src/db/bigtable/pool.rs

@@ -181,6 +181,7 @@ impl Manager for BigtableClientManager {
         }
 
         // Clippy 0.1.73 complains about the `.map_err` being hard to read.
+        // note, this changes to `blocks_in_conditions` for 1.76+
         #[allow(clippy::blocks_in_if_conditions)]
         if !client
             .health_check(&self.settings.table_name)