Skip to content
This repository has been archived by the owner on Aug 7, 2023. It is now read-only.

fix the notification_forever_unsubscribed scenario #82

Open
pjenvey opened this issue Nov 30, 2016 · 2 comments
Open

fix the notification_forever_unsubscribed scenario #82

pjenvey opened this issue Nov 30, 2016 · 2 comments

Comments

@pjenvey
Copy link
Member

pjenvey commented Nov 30, 2016

This scenario is currently no different than notification_forever. It's supposed to unregister the client before beginning the forever loop, but due to a bug it doesn't actually do so (it's missing a yield statement):

https://github.com/mozilla-services/ap-loadtester/blob/6a769/aplt/scenarios.py#L194

I don't understand the intention of the scenario -- if the client's unregistered it won't be accepting the notifications later in the loop. The scenario should be rethought or removed

@rpappalax
Copy link
Contributor

we have several scenarios that test bad client behavior (including this one). sounds like the way forward is to ensure that the server is returning a 404. the load generated by misbehaving client is still valid for generating load to stress the server so we probably should adapt this way it if we can.

@bbangert bbangert added this to the PUSHSVC-0: quality milestone Dec 12, 2016
@pjenvey pjenvey added the ready label Dec 12, 2016
@bbangert bbangert added the p3 label Dec 12, 2016
@pjenvey
Copy link
Member Author

pjenvey commented Aug 21, 2017

IIRC this one should return 410s. This scenario's definitely worth having (even though nginix handles most of these) and shouldn't be removed (should be fixed)

@rpappalax rpappalax changed the title remove the notification_forever_unsubscribed scenario fix the notification_forever_unsubscribed scenario Oct 25, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

3 participants