Skip to content
This repository has been archived by the owner on Jan 12, 2023. It is now read-only.

Use default MainDispatcherLoader implementation after R8 bug is fixed #5121

Closed
mcomella opened this issue Aug 12, 2021 · 1 comment
Closed

Use default MainDispatcherLoader implementation after R8 bug is fixed #5121

mcomella opened this issue Aug 12, 2021 · 1 comment
Labels
performance Performance related issues

Comments

@mcomella
Copy link
Contributor

In #5102, we switched to using the fast service loader because an R8 bug https://issuetracker.google.com/issues/196302685 meant we couldn't use the default optimization. However, it's fragile to use the fast service loader (via our method with proguard) because it relies on the coroutine source code not changing. Once the R8 bug is fixed, let's use the default implementation. Note: the implementations seem equally performant so this is really about maintainability.
@mcomella mcomella added the performance Performance related issues label Aug 12, 2021
@mcomella mcomella mentioned this issue Aug 12, 2021
Closed
@mcomella
Copy link
Contributor Author

Let's not do this: see #5102 (comment) for details.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
performance Performance related issues
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@mcomella