Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Webview not dismissed after signing in to FxA with email credentials #6653

Closed
SimonBasca opened this issue May 21, 2020 · 3 comments · Fixed by #6659
Closed

Webview not dismissed after signing in to FxA with email credentials #6653

SimonBasca opened this issue May 21, 2020 · 3 comments · Fixed by #6659
Assignees
@kaylagalway
Labels
1 Story size Bug 🐞 This is a bug with existing functionality not behaving as expected P1 Issues that need to be completed for the current release QA Verified Issue verified by QA

Comments

@SimonBasca
Copy link
Contributor

Steps to reproduce

  1. Go to Settings -> Sing in to Sync
  2. Tap "Use email"
  3. Input the correct credentials

Expected behavior

  • The webview should be dismissed and the user should be logged in to FxA.

Actual behavior

  • The spinning throttle is displayed.
  • The webview is not dismissed.

Device & build information

  • Device: iPhone Xr
  • Build version: 26.0 (18007)

Notes

  • The flow seems correct after manually dismissing the page by tapping "Cancel" and sync seems to also be working correctly
@SimonBasca SimonBasca added the Bug 🐞 This is a bug with existing functionality not behaving as expected label May 21, 2020
@garvankeeley garvankeeley self-assigned this May 21, 2020
@garvankeeley
Copy link
Contributor

I see this is doing modal navigations where I would expect stack navigations to happen. Looking at it.

@athomasmoz athomasmoz added 1 Story size P1 Issues that need to be completed for the current release labels May 21, 2020
@garvankeeley
Copy link
Contributor

Me playing with this:
https://gist.github.com/garvankeeley/f8dd632b342517a137763d7c620ca28f

@kaylagalway kaylagalway mentioned this issue May 21, 2020
Merged
@SimonBasca
Copy link
Contributor Author

Verified fix on 26.0 (18036).

@SimonBasca SimonBasca added the QA Verified Issue verified by QA label May 22, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@kaylagalway kaylagalway

Labels
1 Story size Bug 🐞 This is a bug with existing functionality not behaving as expected P1 Issues that need to be completed for the current release QA Verified Issue verified by QA
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix issue where email login does not appear to finish mozilla-mobile/firefox-ios
4 participants
@garvankeeley @kaylagalway @SimonBasca @athomasmoz