Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor the existing ShareExtensionHelper to be more flexible and to remove dead code #23340

Open
data-sync-user opened this issue Nov 22, 2024 · 0 comments
Assignees

Comments

@data-sync-user
Copy link
Collaborator

data-sync-user commented Nov 22, 2024

Our current ShareExtensionHelper works on a lick and a promise, is rife with old dead code, and doesn’t meet the new needs of our app for sharing. As well, there are longstanding bugs (e.g. FXIOS-10668) with the current implementation.

This ticket is to refactor the code to provide an explicit interface for sharing so ShareExtensionHelper does not have to operate on broad assumptions of what’s passed into it… especially since this code is used to share content from many different areas of the app (bookmarks, tabs, home screen cards, downloads, long press on pocket articles, etc. etc.).

┆Issue is synchronized with this Jira Task

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants