Skip to content
This repository has been archived by the owner on Feb 20, 2023. It is now read-only.

[Bug] pull to refresh on form submission is buggy #9799

Closed
staktrace opened this issue Apr 8, 2020 · 7 comments
Closed

[Bug] pull to refresh on form submission is buggy #9799

staktrace opened this issue Apr 8, 2020 · 7 comments
Assignees
Labels
🐞 bug Crashes, Something isn't working, .. eng:qa:verified QA Verified Feature:Gesture

Comments

@staktrace
Copy link

staktrace commented Apr 8, 2020

Steps to reproduce

submit a form, then pull to refresh. dialog pops up to resend form contents. hit cancel

Expected behavior

spinner disappears

Actual behavior

spinner doesn't disappear

ThrobberIsNotDismissedAfterCance
https://drive.google.com/file/d/1zDICfILbpbeh-lSyOlarajBrpnAc_icD/view?usp=sharing

Device information

  • Android device: ?
  • Fenix version: ?

┆Issue is synchronized with this Jira Task

@staktrace staktrace added the 🐞 bug Crashes, Something isn't working, .. label Apr 8, 2020
@github-actions github-actions bot added the needs:triage Issue needs triage label Apr 8, 2020
@abodea
Copy link
Member

abodea commented Apr 8, 2020

Thank you for this report @staktrace note that this feature is currently removed from Nightly.
I verified the revert changes today #9770 (comment) here you can find more information.
Note that you will be able to see the changes in the next Nightly.

@abodea abodea closed this as completed Apr 8, 2020
@abodea abodea removed the needs:triage Issue needs triage label Apr 8, 2020
@Mugurell
Copy link
Contributor

This is both a visual issue and one that would prevent other pull to refresh gestures.
Always reproducing in a somewhat common scenario.
Should be fixed for when we enable pull to refresh again.

Reopening it as a breakout of the meta bug.

@Mugurell Mugurell reopened this Jul 22, 2020
@Mugurell Mugurell self-assigned this Aug 14, 2020
@Mugurell
Copy link
Contributor

Filed a new Bugzilla ticket for this - https://bugzilla.mozilla.org/show_bug.cgi?id=1659073
We need a sure way to identify this kind of prompts.

@liuche
Copy link
Contributor

liuche commented Aug 14, 2020

It looks like Agi has responded, so if that's an approach that works, could you remove this from the GV high priority list?

@Mugurell
Copy link
Contributor

It looks like Agi has responded, so if that's an approach that works, could you remove this from the GV high priority list?

I understand Agi laid down a plan for what should be done in GeckoView for supporting this, we still need the patch, so I think this should still be a priority.

@Mugurell Mugurell added the needs:gv GeckoView bug required to fix the issue. See bugzilla.mozilla.org label Aug 27, 2020
@amedyne
Copy link
Contributor

amedyne commented Sep 21, 2020

https://bugzilla.mozilla.org/show_bug.cgi?id=1659073 is fixed.

@Mugurell Mugurell removed the needs:gv GeckoView bug required to fix the issue. See bugzilla.mozilla.org label Oct 16, 2020
@Mugurell Mugurell added the eng:qa:needed QA Needed label Oct 16, 2020
@LaurentiuApahideanSV
Copy link

Verified as fixed on Firefox Preview Nightly 201019 (Build #2015770539).

Devices used:

  • OnePlus 6T (Android 9)
  • Samsung Galaxy S9 (Android 8.0.0)

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
🐞 bug Crashes, Something isn't working, .. eng:qa:verified QA Verified Feature:Gesture
Projects
None yet
Development

No branches or pull requests

6 participants