Skip to content
This repository has been archived by the owner on Feb 20, 2023. It is now read-only.

As a developer I want to receive crash reports #906

Closed
vesta0 opened this issue Mar 8, 2019 · 14 comments
Closed

As a developer I want to receive crash reports #906

vesta0 opened this issue Mar 8, 2019 · 14 comments

Comments

@vesta0
Copy link
Collaborator

vesta0 commented Mar 8, 2019

Why/User Benefit/User Problem

As a developer, I want to receive crash reports when Fenix crashes.

Dependencies

Acceptance Criteria (how do I know when I’m done?)

  • When Fenix crashes in application code or native A-S code, a crash report is sent to Sentry
  • When Fenix crashes in GeckoView, a crash report is sent to Socorro
  • When the user has opted out from sending crash reports (via settings, specified in another user story) no crash reports should be sent. This is only so for Sentry and Soccoro reports. Android will still send reports to the Google Play Store, and that is controlled byt he user at an Android level, not in Fenix.
  • Crash reports should contain enough data to resolve or investigate a crash (ideal situation, but due to the nature of reports, this is simply not always the case)

┆Issue is synchronized with this Jira Task

@vesta0 vesta0 added this to the Milestone 3 Backlog milestone Mar 8, 2019
@st3fan st3fan changed the title Submitting a crash report As a developer I want to receive crash reports Mar 13, 2019
@bifleming bifleming added the Epic label Mar 13, 2019
@sblatz sblatz self-assigned this Mar 15, 2019
@sblatz
Copy link
Contributor

sblatz commented Mar 15, 2019

I noticed we do not have any UX for this. I'm happy to use a Focus-inspired crash page similar to the one found below, but we will need to make a couple changes:

  1. New copy for the description since we're saving history and not a private browser
  2. How "restoring" a session should look (likely a restore session button similar to close tab, with copy that reflects this)

@mheubusch for copy, @lime124 for UX.

Current Implementation

Screen Shot 2019-03-15 at 11 19 03 AM

Let's also take this ticket into account for UX.

@sblatz sblatz added the needs:UX-feedback Needs UX Feedback label Mar 15, 2019
@lime124
Copy link
Collaborator

lime124 commented Mar 15, 2019

@topotropic since there are session related questions. and thanks sblatz for bringing this up! :)

@sblatz
Copy link
Contributor

sblatz commented Mar 18, 2019

What I'm using for now:
Screen Shot 2019-03-18 at 8 30 48 AM

@cadeyrn
Copy link
Contributor

cadeyrn commented Mar 18, 2019

a quick note: Both buttons have the same style in your screen. In Firefox for the desktop you have a primary action and a secondary action in about:tabcrashed, both buttons are differently styled. I don't know if you want to do something similar in Fenix. Maybe this is something to consider. ;-)

@sblatz
Copy link
Contributor

sblatz commented Mar 18, 2019

Updated the buttons as so for now:

image

@topotropic
Copy link

@brampitoyo I think you are working on this atm, can you have a look?

@brampitoyo
Copy link

@topotropic Thanks for pinging me on this. I will have a look at this issue as a part of designing the messaging system (which @shorlander has designed the framework of).

@sblatz Stay tuned for some design! I will first make sure that whatever we use here will look great with the rest of our in-product messaging pages (e.g. 404, SSL errors, malware warnings, etc.)

@sblatz
Copy link
Contributor

sblatz commented Mar 20, 2019

@bbinto, @vesta0: can I get clarification on what Telemetry events we want for this?

@sblatz sblatz added 🙅 waiting Issues that are blocked or has dependencies that are not ready and removed in progress labels Mar 20, 2019
@bbinto
Copy link
Contributor

bbinto commented Mar 20, 2019

@sblatz - added info here #1040

@brampitoyo
Copy link

The UX has been posted on #1102.

@sblatz sblatz added in progress 🙅 waiting Issues that are blocked or has dependencies that are not ready and removed 🙅 waiting Issues that are blocked or has dependencies that are not ready in progress labels Mar 22, 2019
@sblatz
Copy link
Contributor

sblatz commented Mar 22, 2019

This is blocked on #1067 so that I have a baseline for telemetry events.

@sblatz sblatz added Feature:Telemetry in progress and removed needs:UX-feedback Needs UX Feedback 🙅 waiting Issues that are blocked or has dependencies that are not ready labels Mar 22, 2019
@sblatz
Copy link
Contributor

sblatz commented Mar 26, 2019

This feature has been complete for a few days now. The only thing missing from the user story is the telemetry which @boek is helping me out with!

In the future, we should likely break out Telemetry stories so that they don't block an entire feature being QA ready.

@sblatz
Copy link
Contributor

sblatz commented Mar 26, 2019

Per a conversation with Betty, I created a telemetry user story so that this could move to QA.

@sv-ohorvath
Copy link
Contributor

This is verified by QA. There are new issues logged for the bugs found, I'll close this ticket.

@sv-ohorvath sv-ohorvath added eng:qa:verified QA Verified and removed eng:qa:needed QA Needed labels Mar 28, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

9 participants