Skip to content
This repository has been archived by the owner on Feb 20, 2023. It is now read-only.

[Spike] Investigate the need for using the KeyguardManager separately #19709

Closed
jonalmeida opened this issue May 28, 2021 · 4 comments
Closed
Labels
cc-autofill Autofill credit card eng:health Improve code health Feature:Autofill Address and Credit Card autofill pin Issues, features, improvements that are still valid

Comments

@jonalmeida
Copy link
Contributor

jonalmeida commented May 28, 2021

Description

In the BiometricPromptPreferenceFragment and in some places in BaseBrowserFragment, we try to fallback to the KeyguardManager for PIN/password support.

This isn't something that should be needed since we allow PIN/password as a fallback when we make a request through the Biometric support library. The biometric library also abstracts out the correct calls for backward compatibility for devices that do not have support for full support.

Something we could adjust is the code checking for biometric support for DEVICE_CREDENTIAL.

Deliverables

  • Can we remove the complexities of the KeyguardManager from our code base and use the AndroidX library alone? The less code, the better. :)
  • If we do need it, can we hide those within the BiometricPromptFeature so that it can be used in multiple places since we have two separate impls of a similar code flow?

┆Issue is synchronized with this Jira Task

@jonalmeida jonalmeida added eng:health Improve code health Feature:Autofill Address and Credit Card autofill cc-autofill Autofill credit card labels May 28, 2021
@github-actions github-actions bot added the needs:triage Issue needs triage label May 28, 2021
@jonalmeida jonalmeida changed the title [Spike] Investigate the need for using the KeyguardManager individually [Spike] Investigate the need for using the KeyguardManager separately May 28, 2021
@amedyne amedyne removed the needs:triage Issue needs triage label Jun 1, 2021
@stale
Copy link

stale bot commented Mar 16, 2022

See: #17373 This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the wontfix label Mar 16, 2022
@jonalmeida
Copy link
Contributor Author

I came across this issue again when reviewing the backport of BiometricPromptFeature here: mozilla-mobile/android-components#12291

I see that we are using the KeyguardManager in components as well for feature-autofill authentication and I'm still unsure why we need both.

@stale
Copy link

stale bot commented Dec 11, 2022

See: #17373 This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the wontfix label Dec 11, 2022
@jonalmeida jonalmeida added pin Issues, features, improvements that are still valid and removed wontfix labels Dec 11, 2022
@boek
Copy link
Contributor

boek commented Jan 31, 2023

Moved to bugzilla: https://bugzilla.mozilla.org/show_bug.cgi?id=1814143

Change performed by the Move to Bugzilla add-on.

@boek boek closed this as completed Jan 31, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
cc-autofill Autofill credit card eng:health Improve code health Feature:Autofill Address and Credit Card autofill pin Issues, features, improvements that are still valid
Projects
None yet
Development

No branches or pull requests

3 participants