Skip to content
This repository has been archived by the owner on Feb 20, 2023. It is now read-only.

Scrollable full-height three-dot menu #18989

Closed
mrandreastoth opened this issue Apr 13, 2021 · 5 comments
Closed

Scrollable full-height three-dot menu #18989

mrandreastoth opened this issue Apr 13, 2021 · 5 comments
Labels
needs:triage Issue needs triage

Comments

@mrandreastoth
Copy link

mrandreastoth commented Apr 13, 2021

#17772 was a mistake. I've read the ticket and there is no logical justification to force a reduced display height of the menu when the current orientation allows the complete menu to be shown. By the ticket's own logic, this would mean that an app, any app, should only utilise the maximum height based on the minimum height of the device's possible orientations! Seriously, the correct solution would, and should be, that the menu is always rendered to its full height even if the current orientation doesn't fit it and that the menu is scrollable, just like a webpage. That is the correct solution, and not what the ticket describes and implements.

┆Issue is synchronized with this Jira Task

@github-actions github-actions bot added the needs:triage Issue needs triage label Apr 13, 2021
@cadeyrn
Copy link
Contributor

cadeyrn commented Apr 13, 2021

mistake […] there is no logical justification […] Seriously […] the correct solution […] That is the correct solution, and not what the ticket describes and implements

It is certainly fair to say that not everyone likes it. But it's not true to say that your preferred implementation is the only correct solution and everything else is wrong. And to be honest, your choice of words is surely not the most helpful to change their mind… The best arguments are… well, arguments, not derogatory language.

The expandable menu is easier to use for people who prefer to use their smartphone with only one hand. In fact I am not the only one who is interested in improvements for the one-hand usage, you will find other people in other issues in this issues tracker as well who advocated for one-hand usage improvements. So please respect that your opinion is not everyone's opinion.

By the way, Firefox is not the first application doing something like that. For example Firefox Lite - it uses a scrollable (and never expanding) menu so that everything can be reached with one hand. Or Oxygen OS, the operating system for OnePlus smartphones. It does something very similar in their apps like settings, messages or contacts: It does not use the full height in the first view so that you can reach everything with one hand (it shows a large headline and a large empty space at top in the first view, so no interactable content) but uses the full height once you scroll. And they were also not the first…

@andreicristianpetcu
Copy link

andreicristianpetcu commented Apr 14, 2021

My most common buttons are by default hidden: back, share, refresh and forward. Am I using it wrong? :)

Screenshot_20210414-221133_Firefox_Nightly
Screenshot_20210414-221137_Firefox_Nightly

I never click new tab, downloads, history, report site issue or sync.

@andreicristianpetcu
Copy link

Long press on the triangular back button is not the same as long press on the arrow button. The arrow button shows tab history on long press. The triangular button used to do this also but not anymore.
Screenshot_20210414-222314_Firefox_Nightly

@cadeyrn
Copy link
Contributor

cadeyrn commented Apr 14, 2021

My most common buttons are by default hidden: back, share, refresh and forward. Am I using it wrong? :)

This is #18591 and almost there.

Long press on the triangular back button is not the same as long press on the arrow button. The arrow button shows tab history on long press. The triangular button used to do this also but not anymore.

Works for me. You should open a separate issue for that.

@eliserichards
Copy link

@andreicristianpetcu the sticky footer for the nav buttons has landed in Android Components and we are waiting for the version to be updated in Fenix. Your buttons will be back soon! 👍

Closing this issue in favor of #18591

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
needs:triage Issue needs triage
Projects
None yet
Development

No branches or pull requests

4 participants