Skip to content
This repository has been archived by the owner on Feb 20, 2023. It is now read-only.

[Feature] Add three-dot menu icons back #17872

Closed
eliserichards opened this issue Feb 5, 2021 · 3 comments
Closed

[Feature] Add three-dot menu icons back #17872

eliserichards opened this issue Feb 5, 2021 · 3 comments
Assignees
Labels
E2 Estimation Point: easy, half a day to 2 days eng:qa:not-needed Added by QA to issues that cannot be tested Feature:MainMenu The three-dot menu that is seen on the browser and homescreen. MR1 Issues that are needed for the MR1 2021 release.
Milestone

Comments

@eliserichards
Copy link

eliserichards commented Feb 5, 2021

Meta: #17796
Followup to #17771
UX point of contact: @violasong (Victoria)

Figma designs (bottom right, labeled "new tab menu"): https://www.figma.com/file/NHu4cTmzfYgi3QJz5DIDWD/Fenix-Toolbar-Menus?node-id=0%3A1

Acceptance criteria

#17771 removed some icons on the three-dot menu, but the designs have changed and we are now keeping the icons. This issue is to add those icons back in.

Add the ability to remove toolbar menu icons in menu items. This should be reflected in the fenix home menu and the main three-dot menu.
See files in AC:

  • BrowserMenuImageText
  • BrowserMenuHighlightableItem
  • BrowserMenuImageSwitch
  • etc

Old design
image

┆Issue is synchronized with this Jira Task

@eliserichards eliserichards added needs:ac Needs Android Component Work Feature:MainMenu The three-dot menu that is seen on the browser and homescreen. labels Feb 5, 2021
@github-actions github-actions bot added the needs:triage Issue needs triage label Feb 5, 2021
@eliserichards eliserichards removed the needs:triage Issue needs triage label Feb 5, 2021
@ekager
Copy link
Contributor

ekager commented Feb 8, 2021

@sheikh-azharuddin this is not an appropriate comment. This is your final warning. Next step is banning from participation. Please read up on the CPG for what behavior will not be tolerated in this repo and feel free to file specific issues with pain points you are having if you can do so respectfully.

@mcarare mcarare removed the needs:ac Needs Android Component Work label Feb 11, 2021
@eliserichards eliserichards added the MR1 Issues that are needed for the MR1 2021 release. label Feb 18, 2021
@eliserichards eliserichards added the E2 Estimation Point: easy, half a day to 2 days label Feb 23, 2021
@eliserichards eliserichards changed the title [Feature] Remove three-dot menu icons [Feature] Add three-dot menu icons back Mar 3, 2021
@mcarare
Copy link
Contributor

mcarare commented Mar 8, 2021

@eliserichards Is this issue still valid?

@sheikh-azharuddin
Copy link

The bookmark icon on tabs 3 dot menu is not matching with home screen 3 dot menu bookmark icon

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
E2 Estimation Point: easy, half a day to 2 days eng:qa:not-needed Added by QA to issues that cannot be tested Feature:MainMenu The three-dot menu that is seen on the browser and homescreen. MR1 Issues that are needed for the MR1 2021 release.
Projects
None yet
Development

No branches or pull requests

5 participants