Skip to content
This repository has been archived by the owner on Feb 20, 2023. It is now read-only.

[Pull To Refresh][Bug] Avoid accidental refreshes by forcing a cooldown period after the last scroll gesture #16661

Closed
mstange opened this issue Nov 19, 2020 · 6 comments
Labels
🐞 bug Crashes, Something isn't working, .. Feature:Gesture

Comments

@mstange
Copy link
Contributor

mstange commented Nov 19, 2020

Steps to reproduce

  1. On a scrollable page, scroll down.
  2. Scroll up to the top with a series of quick pans / flings.

Expected behavior

No pull refresh should be triggered during gestures that were intended to only scroll.

Actual behavior

As soon as the top edge of the page is hit, the next gesture instantly triggers pull to refresh.

This does not happen in Chrome. Chrome seems to enforce a cooldown period before pull to refresh is triggered. See this video for a comparison: quick-consecutive-flings.mp4

From experimenting, it feels like the cooldown period is somewhere between 300 and 500ms.

Device information

  • Android device: Moto G5
  • Fenix version: Firefox Nightly

┆Issue is synchronized with this Jira Task

@mstange mstange added the 🐞 bug Crashes, Something isn't working, .. label Nov 19, 2020
@github-actions github-actions bot added the needs:triage Issue needs triage label Nov 19, 2020
@ekager ekager added Feature:Gesture and removed needs:triage Issue needs triage labels Nov 20, 2020
@Mugurell
Copy link
Contributor

Mugurell commented Feb 1, 2021

Judging from the video and a quick test in Chrome,
There is no cooldown per se.
What happens on Chrome is that a swipe up and then down will trigger the overscroll effect instead of the pull to refresh throbber like it happens on Fenix.
Then if you continue to swipe down while the edge effect hasn't finished the gesture will trigger again the overscroll effect and it would be possible to keep this behavior with such swipes for a loong time.

That being said, we should probably do the same. Thank you for filing this!

@stale
Copy link

stale bot commented Aug 1, 2021

See: #17373 This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the wontfix label Aug 1, 2021
@Mugurell Mugurell removed the wontfix label Aug 2, 2021
@ghost
Copy link

ghost commented Sep 2, 2021

I have a similar issue on div with scrollable layout (site without mobile layout), everytime I try to scroll down the content of div I got a refresh and not a scroll.
I use the tricks scroll down and to right. but not always works.

@stale
Copy link

stale bot commented Mar 2, 2022

See: #17373 This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the wontfix label Mar 2, 2022
@Mugurell Mugurell removed the wontfix label Mar 2, 2022
@stale
Copy link

stale bot commented Nov 23, 2022

See: #17373 This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the wontfix label Nov 23, 2022
@Mugurell Mugurell removed the wontfix label Nov 23, 2022
@csadilek
Copy link
Contributor

Moved to bugzilla: https://bugzilla.mozilla.org/show_bug.cgi?id=1807072

Change performed by the Move to Bugzilla add-on.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
🐞 bug Crashes, Something isn't working, .. Feature:Gesture
Projects
None yet
Development

No branches or pull requests

4 participants