Skip to content
This repository has been archived by the owner on Feb 20, 2023. It is now read-only.

[Bug] Reader Mode -> Save To collection saves the moz extension link #13036

Closed
s-ankur opened this issue Jul 28, 2020 · 9 comments
Closed

[Bug] Reader Mode -> Save To collection saves the moz extension link #13036

s-ankur opened this issue Jul 28, 2020 · 9 comments
Labels
🐞 bug Crashes, Something isn't working, .. eng:qa:verified QA Verified Feature:Collections

Comments

@s-ankur
Copy link
Contributor

s-ankur commented Jul 28, 2020

Steps to reproduce

Open a page in reader mode
Save to collection

Expected behavior

Actual URL is saved

Actual behavior

moz-extension url is saved

Device information

  • Android device: Asus Zenfone
  • Fenix version: Nightly

┆Issue is synchronized with this Jira Task

@s-ankur s-ankur added the 🐞 bug Crashes, Something isn't working, .. label Jul 28, 2020
@github-actions github-actions bot added the needs:triage Issue needs triage label Jul 28, 2020
@opusforlife2
Copy link

What if the user wants to deliberately save the page in their collection in Reader Mode? So that it directly shows up that way when they open it later?

You still have the option of tapping back and saving the page in your collection that way.

@s-ankur
Copy link
Contributor Author

s-ankur commented Aug 7, 2020

oh, I hadn't thought about that. If so then perhaps it should save with a more readable link and a favicon

@s-ankur
Copy link
Contributor Author

s-ankur commented Aug 7, 2020

According @csadilek's comment in #13398 this is indeed a bug and not a feature.

@csadilek
Copy link
Contributor

csadilek commented Aug 7, 2020

@s-ankur @opusforlife2 yes, the way I see it, we'd want to show the original URL, but keep the page in reader mode if the user decides to add it to the collection while in reader mode. So, we should add the reader page (moz-extension link), but show the nicer / original URL.

@s-ankur
Copy link
Contributor Author

s-ankur commented Aug 7, 2020

@csadilek what about bookmarks and top sites, as the moz-extension link is saved there as well

@csadilek
Copy link
Contributor

csadilek commented Aug 7, 2020

@s-ankur what's the behaviour you would expect / want in these cases? The original page or the reader page?

@csadilek csadilek added Feature:Collections and removed needs:triage Issue needs triage labels Aug 7, 2020
@s-ankur
Copy link
Contributor Author

s-ankur commented Aug 7, 2020

Seeing as bookmarks can be synced, the moz extension link would make it unusable on another device (and probably an unwelcome surprise). But as @opusforlife2 said it might be useful in some cases. So I'm not sure. If there was a portable way to save reader mode urls it would be ideal

@opusforlife2
Copy link

Absolutely. There should definitely be a portable way to save the Reader Mode link or share it with someone, or send it to another device entirely.

@data-sync-user data-sync-user changed the title [Bug] Reader Mode -> Save To collection saves the moz extension link FNX3-22052 ⁃ [Bug] Reader Mode -> Save To collection saves the moz extension link Aug 11, 2020
@data-sync-user data-sync-user changed the title FNX3-22052 ⁃ [Bug] Reader Mode -> Save To collection saves the moz extension link FNX-14205 ⁃ [Bug] Reader Mode -> Save To collection saves the moz extension link Aug 11, 2020
@data-sync-user data-sync-user changed the title FNX-14205 ⁃ [Bug] Reader Mode -> Save To collection saves the moz extension link FNX2-15630 ⁃ [Bug] Reader Mode -> Save To collection saves the moz extension link Aug 11, 2020
@kbrosnan kbrosnan changed the title FNX2-15630 ⁃ [Bug] Reader Mode -> Save To collection saves the moz extension link [Bug] Reader Mode -> Save To collection saves the moz extension link Aug 29, 2020
@AndiAJ
Copy link
Collaborator

AndiAJ commented Feb 18, 2021

Hi, verified as fixed on:
Nightly 210218
Beta 86.0.0-beta.5
86.1.0 RC1

using the following devices:
• Google Pixel 3a (Android 11)
• Nexus 9 (Android 9) [EMULATOR]
• OnePlus A3 (Android 6.0.1)

@AndiAJ AndiAJ closed this as completed Feb 18, 2021
@AndiAJ AndiAJ added the eng:qa:verified QA Verified label Feb 18, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
🐞 bug Crashes, Something isn't working, .. eng:qa:verified QA Verified Feature:Collections
Projects
None yet
Development

No branches or pull requests

4 participants