Skip to content
This repository has been archived by the owner on Feb 20, 2023. It is now read-only.

IllegalArgumentExceptionorg.mozilla.geckoview.GeckoWebExecutor: URI scheme must be http or https #11149

Closed
liuche opened this issue Jun 2, 2020 · 8 comments
Closed

IllegalArgumentExceptionorg.mozilla.geckoview.GeckoWebExecutor: URI scheme must be http or https #11149

liuche opened this issue Jun 2, 2020 · 8 comments
Assignees
@Amejia481
Labels
b:crash Crashes Fenix: should link to Sentry, Crash-Stats or GPlay info 🐞 bug Crashes, Something isn't working, .. needs:ac Needs Android Component Work

Comments

@liuche
Copy link
Contributor

liuche commented Jun 2, 2020 •
edited by data-sync-user
Loading

Sentry report: https://sentry.prod.mozaws.net/operations/firefox-nightly/issues/8595438/?query=release%3Aorg.mozilla.fenix-5.1.0

IllegalArgumentExceptionorg.mozilla.geckoview.GeckoWebExecutor in fetch
fatalURI scheme must be http or https

Seen in 5.1 even though it should have been fixed already.

┆Issue is synchronized with this Jira Task
@liuche liuche added 🐞 bug Crashes, Something isn't working, .. b:crash Crashes Fenix: should link to Sentry, Crash-Stats or GPlay info labels Jun 2, 2020
@liuche liuche changed the title [Bug] IllegalArgumentExceptionorg.mozilla.geckoview.GeckoWebExecutor in fetch fatal, URI scheme must be http or https [Bug] IllegalArgumentExceptionorg.mozilla.geckoview.GeckoWebExecutor: URI scheme must be http or https Jun 2, 2020
@liuche liuche changed the title [Bug] IllegalArgumentExceptionorg.mozilla.geckoview.GeckoWebExecutor: URI scheme must be http or https IllegalArgumentExceptionorg.mozilla.geckoview.GeckoWebExecutor: URI scheme must be http or https Jun 2, 2020
@github-actions github-actions bot added the needs:triage Issue needs triage label Jun 2, 2020
@ekager
Copy link
Contributor

ekager commented Jun 2, 2020

Looks like this is similar to mozilla-mobile/android-components#6314 ie that it is the same trace in AbstractFetchDownloadService

@ekager ekager added the needs:ac Needs Android Component Work label Jun 2, 2020
@liuche
Copy link
Contributor Author

liuche commented Jun 3, 2020

This looks like it landed in AC 38, so it should definitely not be showing up in Fenix 5.1/AC 42.

@Amejia481
Copy link
Contributor

Amejia481 commented Jun 3, 2020 •
edited
Loading

It also looks similar to mozilla-mobile/android-components#7160 it could be the case that the user was trying to download a file with a url that contains spaces

@ekager
Copy link
Contributor

ekager commented Jun 3, 2020

@Amejia481 would the sanitizing in mozilla-mobile/android-components#7160 also take care of a URL with spaces?

@Amejia481
Copy link
Contributor

In that pr we are only sanitizing in browser-icons this issue came from downloads, we should do sanitizing there too :)

@ekager
Copy link
Contributor

ekager commented Jun 4, 2020

Duh.
Filed mozilla-mobile/android-components#7238

@ekager ekager mentioned this issue Jun 4, 2020
Closed
@ekager ekager removed the needs:triage Issue needs triage label Jun 4, 2020
@Amejia481 Amejia481 self-assigned this Jun 4, 2020
@liuche
Copy link
Contributor Author

liuche commented Jun 16, 2020

Will look for this to decline in 5.2 Sentry.

@liuche
Copy link
Contributor Author

liuche commented Jun 27, 2020

Don't see this in 5.2 anymore, closing.

@liuche liuche closed this as completed Jun 27, 2020
@data-sync-user data-sync-user changed the title IllegalArgumentExceptionorg.mozilla.geckoview.GeckoWebExecutor: URI scheme must be http or https FNX2-16360 ⁃ IllegalArgumentExceptionorg.mozilla.geckoview.GeckoWebExecutor: URI scheme must be http or https Jul 31, 2020
@data-sync-user data-sync-user changed the title FNX2-16360 ⁃ IllegalArgumentExceptionorg.mozilla.geckoview.GeckoWebExecutor: URI scheme must be http or https FNX3-14425 ⁃ IllegalArgumentExceptionorg.mozilla.geckoview.GeckoWebExecutor: URI scheme must be http or https Aug 10, 2020
@data-sync-user data-sync-user changed the title FNX3-14425 ⁃ IllegalArgumentExceptionorg.mozilla.geckoview.GeckoWebExecutor: URI scheme must be http or https FNX-12021 ⁃ IllegalArgumentExceptionorg.mozilla.geckoview.GeckoWebExecutor: URI scheme must be http or https Aug 11, 2020
@data-sync-user data-sync-user changed the title FNX-12021 ⁃ IllegalArgumentExceptionorg.mozilla.geckoview.GeckoWebExecutor: URI scheme must be http or https FNX2-16360 ⁃ IllegalArgumentExceptionorg.mozilla.geckoview.GeckoWebExecutor: URI scheme must be http or https Aug 11, 2020
@data-sync-user data-sync-user changed the title FNX2-16360 ⁃ IllegalArgumentExceptionorg.mozilla.geckoview.GeckoWebExecutor: URI scheme must be http or https IllegalArgumentExceptionorg.mozilla.geckoview.GeckoWebExecutor: URI scheme must be http or https May 18, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@Amejia481 Amejia481

Labels
b:crash Crashes Fenix: should link to Sentry, Crash-Stats or GPlay info 🐞 bug Crashes, Something isn't working, .. needs:ac Needs Android Component Work
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@Amejia481 @liuche @ekager @data-sync-user