Skip to content
This repository has been archived by the owner on Feb 20, 2023. It is now read-only.

[Bug] It is too hard to save/move a selection of tabs into collections via tab tray #10371

Closed
yoasif opened this issue May 2, 2020 · 9 comments
Labels
🐞 bug Crashes, Something isn't working, .. Feature:Collections Feature:Tabs

Comments

@yoasif
Copy link
Contributor

yoasif commented May 2, 2020

Steps to reproduce

  1. Open a page
  2. Go to open tabs
  3. tap and hold on a tab

Expected behavior

UI appears that allows me to save tab into a collection, like what used to happen on home.

Actual behavior

Nothing happens. Unless I try to save a collection and hit back (not very discoverable), I am forced to save my entire open tab stack to a collection any time I want to add tabs to a collection.

Device information

  • Android device: pixel 2
  • Fenix version: latest nightly

┆Issue is synchronized with this Jira Task

@yoasif yoasif added the 🐞 bug Crashes, Something isn't working, .. label May 2, 2020
@yoasif yoasif changed the title [Bug] It is too hard to save/move items into collections via tab tray [Bug] It is too hard to save/move a selection of tabs into collections via tab tray May 2, 2020
@github-actions github-actions bot added the needs:triage Issue needs triage label May 2, 2020
@cadeyrn
Copy link
Contributor

cadeyrn commented May 2, 2020

Duplicate of #10163.

@yoasif
Copy link
Contributor Author

yoasif commented May 2, 2020

I don't think this is a dupe of that; you can already save individual tabs into collections, but the UI differs from the Library.

@cadeyrn
Copy link
Contributor

cadeyrn commented May 2, 2020

#10163 is about implementing a multiselect behaviour that is consistent with the multiselect behaviour of the library. It's not possible to have both, #10163 and the long press behaviour of the start screen. So it's clearly a duplicate of #10163 because #10163 will implement the long press behaviour which allows to add a single tab to a collection.

@yoasif
Copy link
Contributor Author

yoasif commented May 2, 2020

@cadeyrn You can still get the same multi-select in tab tray as previously appeared in home, just tap "Save to collection" and hit the back button. The styling there is clearly different from the Library, and that is my understanding of #10163.

My issue here is that it is simply far too undiscoverable to get to the point of selection, because Fenix really wants me to save all my tabs to a collection every time.

EDIT: I actually don't know how much this is even worth fixing, in all reality, because dragging tabs into collections feels superior in Chrome's dev browser. 🤦

@cadeyrn
Copy link
Contributor

cadeyrn commented May 2, 2020

You can still get the same multi-select in tab tray as previously appeared in home, just tap "Save to collection" and hit the back button.

I know. But my comment was not about this behaviour at all…

Your issue is about the behaviour when long pressing a tab, I refer to your "steps to reproduce". And #10163 is about exactly the same: To get a consistent behaviour with the library the multiselect mode has to be enabled when long pressing a row. Long pressing a tab can only trigger one behaviour. And the planned behaviour is covered by #10092:

Multi-select on tab tray to save open tabs to a Collection is consistent to how multi-select on History/Bookmarks view works

That's my understanding at least. 🙂

@yoasif
Copy link
Contributor Author

yoasif commented May 2, 2020

If it is a dupe, it is a dupe. I'll point out that #10163 says "update" the tab tray multiselect, which to me meant that we'd simply be updating the screen that appears when you tap "Save to collection" and hit the back button.

I can't read what isn't in the issue. 😄

@vesta0
Copy link
Collaborator

vesta0 commented Jun 28, 2020

@yoasif for now you could still add a single tab to a collection by tapping on "save to collection" in the tab toolbar menu - without having to save all your tabs to a collection every time.

Screenshot_20200628-004338

@data-sync-user data-sync-user changed the title [Bug] It is too hard to save/move a selection of tabs into collections via tab tray FNX-3476 ⁃ [Bug] It is too hard to save/move a selection of tabs into collections via tab tray Jul 30, 2020
@ekager
Copy link
Contributor

ekager commented Jul 30, 2020

Can we close this issue now that we can "tap and hold on a tab" in the tabs tray as part of multiselect and adding a single tab is available in the browsing menu?

@yoasif
Copy link
Contributor Author

yoasif commented Jul 30, 2020

@ekager happy to close. I honestly hadn't tried the new feature - it looks good!

@yoasif yoasif closed this as completed Jul 30, 2020
@data-sync-user data-sync-user changed the title FNX-3476 ⁃ [Bug] It is too hard to save/move a selection of tabs into collections via tab tray FNX3-13845 ⁃ [Bug] It is too hard to save/move a selection of tabs into collections via tab tray Aug 10, 2020
@data-sync-user data-sync-user changed the title FNX3-13845 ⁃ [Bug] It is too hard to save/move a selection of tabs into collections via tab tray FNX-3476 ⁃ [Bug] It is too hard to save/move a selection of tabs into collections via tab tray Aug 11, 2020
@data-sync-user data-sync-user changed the title FNX-3476 ⁃ [Bug] It is too hard to save/move a selection of tabs into collections via tab tray FNX2-13144 ⁃ [Bug] It is too hard to save/move a selection of tabs into collections via tab tray Aug 11, 2020
@kbrosnan kbrosnan changed the title FNX2-13144 ⁃ [Bug] It is too hard to save/move a selection of tabs into collections via tab tray [Bug] It is too hard to save/move a selection of tabs into collections via tab tray Aug 27, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
🐞 bug Crashes, Something isn't working, .. Feature:Collections Feature:Tabs
Projects
None yet
Development

No branches or pull requests

9 participants