Skip to content
This repository has been archived by the owner on Dec 14, 2021. It is now read-only.

Investigate why BackPressedCallback is disabled #896

Open
jhugman opened this issue Aug 30, 2019 · 0 comments
Open

Investigate why BackPressedCallback is disabled #896

jhugman opened this issue Aug 30, 2019 · 0 comments
Labels
task Issue describes a task that needs to be completed but is not a defect or enhancement in itself. tech-debt

Comments

@jhugman
Copy link
Contributor

jhugman commented Aug 30, 2019

In #804 we found that the BackPressedCallback listener is not being enabled. We're not sure why.

Current theory is that it was disabled when the AppRoutePresenter and AutofillRoutePresenter was being merged.

Without it, the back stack history (as maintained by the RouteStore is likely getting out of sync with the actual back stack). Recall that the RouteStore maintains the current route so whenever the app is backgrounded, it needs to detect or fakeout what the actual back stack is doing.

Outcomes of this:

  • re-enable the back button pressed callback for both route presenters.
  • better understanding of the autofill route presenter — especially around testing. That no tests are failing either way is a problem.
  • or deleting the callback all together.
@jhugman jhugman added the task Issue describes a task that needs to be completed but is not a defect or enhancement in itself. label Aug 30, 2019
@eliserichards eliserichards changed the title Investigate why BackPressedCallback is disabled. Investigate why BackPressedCallback is disabled Sep 30, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
task Issue describes a task that needs to be completed but is not a defect or enhancement in itself. tech-debt
Projects
None yet
Development

No branches or pull requests

2 participants