Skip to content
This repository has been archived by the owner on Nov 27, 2019. It is now read-only.

Show a warning when using relative icon paths #522

Open
johannhof opened this issue Apr 10, 2016 · 3 comments
Open

Show a warning when using relative icon paths #522

johannhof opened this issue Apr 10, 2016 · 3 comments

Comments

@johannhof
Copy link

In https://github.com/mozilla-jetpack/jpm/blob/master/lib/rdf.js#L90 we use a hack to replace relative icon paths with absolute resource:// URLs, since relative icon paths are not supported in Firefox (yet?).

This should not be the default way to go because:

  • resource:// is not guaranteed to be around forever
  • (more importantly) the icon will not be displayed if the add-on is disabled

Hence we should log a short warning that it is recommended to use a file called icon.png / icon64.png in the root directory instead and link to https://developer.mozilla.org/en-US/Add-ons/Install_Manifests#iconURL

@yan12125
Copy link
Contributor

Maybe also provide another option to use chrome registrations? Personally I don't think forcing everyone to put icon files on the top level is a good idea.

@Croydon
Copy link

Croydon commented Apr 10, 2016

I feel like the best solution would be to fix this in Firefox.

@johannhof
Copy link
Author

Firefox fix is tracked in https://bugzilla.mozilla.org/show_bug.cgi?id=1141839

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

3 participants