Skip to content
This repository has been archived by the owner on Nov 27, 2019. It is now read-only.

SeaMonkey extensions get incorrect maxVersion. #518

Open
musically-ut opened this issue Mar 19, 2016 · 3 comments
Open

SeaMonkey extensions get incorrect maxVersion. #518

musically-ut opened this issue Mar 19, 2016 · 3 comments

Comments

@musically-ut
Copy link

While porting Lovely forks to SeaMonkey, I ran into this rather arcane issue.

The current release used the version 43 as the maximum version, which has changed in HEAD to *.

However, SeaMonkey's valid application versions, for some odd reason, do not have * as a valid option.

Hence, the install.rdf generated with only a minVersion specified for SeaMonkey is deemed invalid when uploaded to Addons site because:

  • (With the release 1.0.6): 43 is an invalid max version for SeaMonkey
  • (With HEAD): * is an invalid max version for SeaMonkey.

I am not sure what is the best way to resolve the issue. Perhaps having an GUID/engine aware MAX_VERION with the * fallback for unknown platforms would be the best solution?

Alternatively, what is the best channel to contact Mozilla to allow * for SeaMonkey as well?

@musically-ut musically-ut changed the title Seamonkey extensions get incorrect maxVersion. SeaMonkey extensions get incorrect maxVersion. Mar 19, 2016
@asamuzaK
Copy link
Contributor

Even if * is implemented, default MIN_VERSION (38.0a1) will still be invalid for SeaMonkey.
Isn't it?

So, I think it's better to add "engines" field in package.json
"engines": { "firefox": ">=38.0a1 <=*", "seamonkey": ">=2.0a <=2.40" }

package.json - Mozilla | MDN

@musically-ut
Copy link
Author

Yes, that is what I had done. However, that does mean that I have to keep releasing new version of my addon as newer versions of SeaMonkey are released. It should not be needed since I am using stable SDK API. That, in my opinion, should be the desired behavior if the MAX_VERSION is omitted.

However, if I omit specifying the MAX_VERSION, then jpm would substitute it by *, irrespective of whether it is a valid version for the engine or not. I think that is a bug.

Alternatively, it may be easier to just add * as a valid version for SeaMonkey: mozilla/addons#74

@freaktechnik
Copy link
Contributor

Doesn't SeaMonkey ignore the max version by default too? So it's just AMO that actually looks at it (and decides to show an extension based on it or not, I think).

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants