Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Display of mozillians groups doesn't give actual group name #518

Open
gene1wood opened this issue Nov 20, 2019 · 2 comments
Open

Display of mozillians groups doesn't give actual group name #518

gene1wood opened this issue Nov 20, 2019 · 2 comments

Comments

@gene1wood
Copy link
Contributor

gene1wood commented Nov 20, 2019

When viewing the access groups that a user is a member of in one's profile on people.mozilla.org, the group name for the mozillians groups strips the leading mozilliansorg_ prefix from the name

Screenshot of profile

as a result, though the names look nicer, they aren't usable for purposes of access control.

For example if in my RP I grant access to the access group dinopark-preview-access, the users in that mozillians group don't have access. I have to instead grant access to mozilliansorg_dinopark-preview-access

The case where this is affecting me is that in rolling out federated access to AWS for all of our AWS accounts, each AWS account holder needs to create AWS roles and grant access to the access groups that they want for each role. If they go to people.mozilla.org (the only place users can see access groups) to see what groups they're part of to inform what groups they should grant access to, if they add an LDAP group everything is fine. If they add a mozillians group it will just silently not work.

Can we change how the mozillians groups are visualized to show the actual group name?

Ideas for how to do this could be

  • Show both the actual mozillians group name in the same visual style of the LDAP groups as well as a hyperlinked and prefix-stripped name as we have now in the mozillians section
  • Show the real group name hyperlinked instead of the stripped name
  • Show the stripped name with an icon that when clicked reveals the real name of the group (that has some tooltip that explains what's going on)
@klahnakoski
Copy link

@gene1wood

I have to instead grant access to mozillians_dinopark-preview-access

Sorry, was that supposed to be mozillians_dinopark-preview-access or mozilliansorg_dinopark-preview-access?

@gene1wood
Copy link
Contributor Author

@klahnakoski Yes, totally a typo on my part, I'll edit/fix the original comment with that typo, thank you for catching it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants