Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Org chart] Expand/collapse buttons are invisible with a dark theme #172

Open
PaulBone opened this issue Dec 13, 2018 · 6 comments
Open

Comments

@PaulBone
Copy link

PaulBone commented Dec 13, 2018

Expand/collapse buttons are invisible with a dark theme

I use a dark theme for accessability reasons, See http://paul.bone.id.au/2017/11/26/how-i-see-the-web/ for information about my disability, I use the "Dark Background and Light Text" addon for Firefox.

To Reproduce

  1. Install the dark background and light text theme,
  2. Go to the org chart.

Expected behavior
I assume these are black images with a transparent background. If they had a white outline or were text rather than images then they could be more accessabile for me.

Screenshots
I deleted the screenshot since it contains the Mozilla org chart, and I don't know if that should be public.

Desktop (please complete the following information):

  • OS: Linux Mint 19
  • Browser Firefox with Dark Background and Light Text extension.
  • Version Nightly 66
@mbransn
Copy link

mbransn commented Dec 13, 2018

@PaulBone (hello!) and thanks for flagging, quite helpful.

The + - UI are currently SVGs -- @hidde is there a way to maintain their vector scalability, while also enabling a contrast render for the default and hover states?

@PaulBone
Copy link
Author

Oh hey @mbransn!

@hidde
Copy link
Contributor

hidde commented Dec 14, 2018

Hey @PaulBone , @mbransn . Thanks for flagging. In our internal Jira board, we do actually have an issue for what I believe is the equivalent of this issue in Windows high contrast mode.

@mbransn: yes, we can totally retain vector scalability! The tricky bit would be to detect this dark background mode. There is a CSS media query, and it looks like it is coming to Firefox, too. I'll dig into it deeper, and see if there's a way without feature detection. To be continued!

@hidde
Copy link
Contributor

hidde commented Dec 14, 2018

Quick update: I've investigated this: basically, only icons that are included as images (<img>) have the problem, those that are inline svgs (<svg>) work fine in the plugin. Will fix!

@mbransn
Copy link

mbransn commented Dec 14, 2018

Brilliant, thanks @hidde 🌮

@hidde
Copy link
Contributor

hidde commented Dec 21, 2018

Hi @PaulBone, this has been addressed this week. We've also updated some other icons throughout the site to work wit the Firefox dark mode (as well as Windows' built-in dark mode) while we were at it.

Please let us know if you encounter any further issues with dark / high contrast mode

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants