Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Skip CI if file changes are .md or .rst #76

Open
davetcoleman opened this issue Jun 26, 2019 · 5 comments
Open

Skip CI if file changes are .md or .rst #76

davetcoleman opened this issue Jun 26, 2019 · 5 comments
Assignees

Comments

@davetcoleman
Copy link
Member

davetcoleman commented Jun 26, 2019

This would save build time.

For inspiration, see #73

@rhaschke
Copy link
Contributor

IMHO adding such extra rules doesn't make sense. We are using moveit_ci for both, C++ compiling (which is already sped up via ccache) and for moveit_tutorials / docs. The latter needs to run for .rst files as well.

@davetcoleman
Copy link
Member Author

Interesting point, but I don't think this this will affect that.

  • If a change to moveit_tutorials is only for .rst, there is no way i can see it breaking the code build, so we don't need moveit_ci
  • The webpage testing of moveit_tutorials would still run, after moveit_ci is skipped. See here.

This would help with other use case of ours for moveit_ci.

@rhaschke
Copy link
Contributor

My concern is mainly that such a change renders moveit_ci very specific to our MoveIt use case.
On the other hand, we can "only" save ~10min of building time.

@davetcoleman
Copy link
Member Author

I don't think its specific... what project would require you to test all code when only a documentation file is updated? None.

10 min... I thought we were hitting time limits on Travis sometimes? Like 50 min.

Also regarding "very specific" to moveit, that is the name of the repo :-)

Anyway, I'm not asking you to add this feature, but rather our intern @simonGoldstein

@rhaschke
Copy link
Contributor

If you insist, go ahead. I just wanted to formulate my concerns, which I have done.
Although Simon will implement the feature, I will be probably the one who needs to review and maintain this feature in future 😉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants