-
Notifications
You must be signed in to change notification settings - Fork 39
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Skip CI if file changes are .md or .rst #76
Comments
IMHO adding such extra rules doesn't make sense. We are using moveit_ci for both, C++ compiling (which is already sped up via ccache) and for moveit_tutorials / docs. The latter needs to run for .rst files as well. |
Interesting point, but I don't think this this will affect that.
This would help with other use case of ours for moveit_ci. |
My concern is mainly that such a change renders moveit_ci very specific to our MoveIt use case. |
I don't think its specific... what project would require you to test all code when only a documentation file is updated? None. 10 min... I thought we were hitting time limits on Travis sometimes? Like 50 min. Also regarding "very specific" to moveit, that is the name of the repo :-) Anyway, I'm not asking you to add this feature, but rather our intern @simonGoldstein |
If you insist, go ahead. I just wanted to formulate my concerns, which I have done. |
This would save build time.
For inspiration, see #73
The text was updated successfully, but these errors were encountered: