Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TLSv1.3 not working. error sending request #85

Open
baek-sang opened this issue Sep 12, 2024 · 2 comments
Open

TLSv1.3 not working. error sending request #85

baek-sang opened this issue Sep 12, 2024 · 2 comments
Assignees
Labels
bug Something isn't working

Comments

@baek-sang
Copy link

What happened?

  • valid cert ( let's encrypt )
  • only TLSv1.3
  • Error when enabling only TLSv1.3 on NGINX. Enable TLSv1.2 and it works.
  • In bruno, it works without any problems.
yaak-error yaak-log

Version

2024.8.2

What operating system are you on?

Windows

Relevant log output

[2024-09-12][18:21:09][WARN][tao::platform_impl::platform::event_loop::runner] NewEvents emitted without explicit RedrawEventsCleared
[2024-09-12][18:21:09][WARN][tao::platform_impl::platform::event_loop::runner] RedrawEventsCleared emitted without explicit MainEventsCleared
[2024-09-12][18:21:16][WARN][tao::platform_impl::platform::event_loop::runner] NewEvents emitted without explicit RedrawEventsCleared
[2024-09-12][18:21:16][WARN][tao::platform_impl::platform::event_loop::runner] RedrawEventsCleared emitted without explicit MainEventsCleared
[2024-09-12][18:21:16][WARN][tauri_app_lib] Failed to send request: error sending request for url (https://my.domain.com)
@baek-sang baek-sang added bug Something isn't working needs triage Bug is waiting to be handled labels Sep 12, 2024
@timcole
Copy link

timcole commented Sep 12, 2024

I believe this is caused by using native-tls in reqwest as native-tls doesn't support TLS 1.3 sfackler/rust-native-tls#140

Switching to rustls-tls-native-roots and adding .use_rustls_tls() to the client builder does work but not sure if @gschier would want to switch away from native-tls or if switching will cause other issues.

Here's a TLS1.3 only API you can test with https://booster.spaceflight.live/?query=query%7Blaunch%28id%3A%22ydrQbuXwPEo%22%29%7Bname%7D%7D

@gschier gschier added good first issue Good for newcomers and removed needs triage Bug is waiting to be handled labels Sep 15, 2024
@gschier
Copy link
Member

gschier commented Sep 26, 2024

Would like to stay on native TLS if possible, as it gets you nice things like automatically picking up any user-installed certs.

I'm not totally opposed to bundling both, but that's quite a pain to maintain going forward.

@gschier gschier removed the good first issue Good for newcomers label Sep 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants