Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Github relative #43

Merged
merged 4 commits into from
Mar 2, 2016
Merged

Github relative #43

merged 4 commits into from
Mar 2, 2016

Conversation

mattn
Copy link
Contributor

@mattn mattn commented Oct 7, 2014

When here is /path/to/ghq/root/github.com/motemen and do ghq get git-pr-release, github.com/motemen/git-pr-release should be expected repository name.

mattn added 4 commits October 8, 2014 01:29
@mattn
gofmt
b9db6b2
@mattn
Handle repository name following after github.com/USER/ on current wo…
61e9f9e 
…rking directory.

For example, here is /path/to/ghq/root/github.com/someone, and do "ghq get foo".
"github.com/someone/foo" is expected name of the repository.
@mattn
Add test
28ef28d
@mattn
Fix path separator issue on windows
e9b7571
@motemen motemen self-assigned this Feb 2, 2015
@motemen
Copy link
Member

motemen commented Feb 27, 2015

Sorry for taking such long time for response.

Currently ghq is not cwd-sensitive, and this PR is breaking current behavior of fetching https://github.com/foo/foo on ghq get foo. And I'd like to preserve ghq's cwd-insensitivity for simplicity as of now.

What if changing the spec to ghq get ./foo not ghq get foo, which starts with relative path syntax and kind of obvious as it shows that the user is concious of current directory?

@mattn
Copy link
Contributor Author

mattn commented Feb 27, 2015

But your README.md says:

'ghq' get [-u] [-p] (<repository URL> | <user>/<project> | <project>)

@motemen
Copy link
Member

motemen commented Feb 27, 2015

I think you mean ghq get <project> part. Yes it does, but it is an abbreviation of github.com/<project>/<project> and not aware of current directory.

motemen added a commit that referenced this pull request Dec 14, 2015
@motemen
Merge remote-tracking branch 'origin/master' into #43-mattn/github-re…
50c0ee8 
…lative
@motemen motemen merged commit e9b7571 into x-motemen:master Mar 2, 2016
motemen added a commit that referenced this pull request Mar 2, 2016
@motemen
Merge pull request #43 from mattn/github-relative
e1a9b8d 
Github relative
@mattn mattn deleted the github-relative branch March 2, 2016 14:49
@motemen
Copy link
Member

motemen commented Mar 3, 2016

Finally merged it, Thank you and sorry such a late merge 🙏

@mattn
Copy link
Contributor Author

mattn commented Mar 3, 2016

No Problem 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@motemen motemen

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mattn @motemen