-
-
Notifications
You must be signed in to change notification settings - Fork 184
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove gomega #142
Merged
Merged
Remove gomega #142
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Songmu
added a commit
that referenced
this pull request
May 1, 2019
## [v0.11.0](v0.10.2...v0.11.0) (2019-05-01) * Delete codes for the services turned down (Google Code and JazzHub) [#144](#144) ([Songmu](https://github.com/Songmu)) * reduce linter warnings [#143](#143) ([Songmu](https://github.com/Songmu)) * remove ghq.import.<subcommand> feature [#137](#137) ([Songmu](https://github.com/Songmu)) * Remove gomega [#142](#142) ([Songmu](https://github.com/Songmu)) * Streamline VCS detection for local repositories [#141](#141) ([Songmu](https://github.com/Songmu)) * introduce table driven test in TestCommandGet [#140](#140) ([Songmu](https://github.com/Songmu)) * "bzr" as Bazaar [#139](#139) ([Songmu](https://github.com/Songmu)) * Support bazaar [#87](#87) ([shigemk2](https://github.com/shigemk2)) * [experimental] support parallel import by using --parallel option [#136](#136) ([Songmu](https://github.com/Songmu)) * add -silent option to get and import [#135](#135) ([Songmu](https://github.com/Songmu)) * Stop exec on unix in the look subcommand in order to share code with windows [#134](#134) ([Songmu](https://github.com/Songmu)) * [list] accept url as a query [#133](#133) ([Songmu](https://github.com/Songmu)) * adjust NewURL() [#132](#132) ([Songmu](https://github.com/Songmu))
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove gomega dependency.
The BDD testing framework is too heavy in Go. It is enough to simply use the Table Driven Test, and particular test can be quickly executed using
-run
option.Also, I think it's not a good idea to add more dependent packages just for the test framework.