Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make configuration API compatible with document model. 配置API适配document模型 #7

Closed
zhenjunMa opened this issue Apr 29, 2021 · 9 comments
Assignees
Labels
kind/enhancement New feature or request stale
Milestone

Comments

@zhenjunMa
Copy link
Contributor

What would you like to be added:

Why is this needed:

@zhenjunMa zhenjunMa added this to the v0.1 milestone Apr 29, 2021
@zhenjunMa zhenjunMa added the kind/enhancement New feature or request label Apr 29, 2021
@tianjipeng
Copy link
Member

@seeflood Can I help with anything?

@seeflood seeflood changed the title 配置API适配document模型 Make configuration API compatible with document model. 配置API适配document模型 Jul 9, 2021
@seeflood
Copy link
Member

seeflood commented Jul 9, 2021

@seeflood Can I help with anything?

Wow,thanks for your support!
This issue is pending, because the new version of configuration API is under discussion.
Besides this,layotto has many things to do:

  • add integration test;
  • add document on how to use layotto(currently we only have some quickstart demo,but that's not enough);
    ......

And I'm preparing for new community tasks this week:

  • add nodejs sdk
  • add python sdk
  • add c/c++ sdk
  • add .net sdk
  • add more sdk api into java sdk
  • add more unit test whereever you like to make layotto's unit test coverage higher(currently it's only 45%)
  • use other components to implement distributed lock API (mongo,cassandra,consul,etc.)

@tianjipeng
Copy link
Member

Let me add integration test first. Is there anything I should pay attention to?

@seeflood
Copy link
Member

seeflood commented Jul 9, 2021

Let me add integration test first. Is there anything I should pay attention to?

Cool,I will assign u
因为在高铁上信号不好,晚点告诉你细节

@seeflood
Copy link
Member

@tianjipeng
抱歉等这么久才回,因为我在研究该咋加集成测试,目前看来有点麻烦,得在github action的workflow中部署多个docker镜像,包含我们依赖的所有组件(redis,etcd,zookeeper等)然后再运行各种demo、判断有没有报错。

我怕你不熟悉项目,搞这个会很难上手,要不我来搞这个,你看下有没有其他感兴趣的任务?

我在 #108 又加了一些任务,包括:

  • 测试类:为runtime/runtime.go和grpc/api.go添加单元测试。这两个文件是layotto的核心引擎代码,各自负责组件生命周期管理(启动、注册、初始化)和grpc请求处理,完成此任务可以很好的了解Layotto架构
  • 文档类:为各类API新增接口文档、新增sdk使用文档(我最近肝了很多文档感觉还是不够……)

@tianjipeng
Copy link
Member

我先来搞一下这两个文件的单测,后面再来看看怎么完善文档

@seeflood
Copy link
Member

我先来搞一下这两个文件的单测,后面再来看看怎么完善文档

感激!!比心ღ( ´・ᴗ・` )

@github-actions
Copy link

github-actions bot commented Nov 2, 2021

This issue has been automatically marked as stale because it has not had recent activity in the last 30 days. It will be closed in the next 7 days unless it is tagged (pinned, good first issue or help wanted) or other activity occurs. Thank you for your contributions.

@github-actions github-actions bot added the stale label Nov 2, 2021
@github-actions
Copy link

This issue has been automatically closed because it has not had activity in the last 37 days. If this issue is still valid, please ping a maintainer and ask them to label it as pinned, good first issue or help wanted. Thank you for your contributions.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/enhancement New feature or request stale
Projects
None yet
Development

No branches or pull requests

3 participants