MOSIP-31617: Sonar Fixes #1537
Open
MOSIP-31617: Sonar Fixes #1537
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 4 commits
July 9, 2024 12:24
Signed-off-by: HimajaDhanyamraju2 <[email protected]>
Signed-off-by: HimajaDhanyamraju2 <[email protected]>
Signed-off-by: HimajaDhanyamraju2 <[email protected]>
vishwa-vyom
requested changes
Jul 10, 2024
...-config-server/src/main/java/io/mosip/kernel/config/server/controller/RefreshController.java
Outdated
Show resolved
Hide resolved
...enerator-service/src/main/java/io/mosip/kernel/vidgenerator/constant/VIDHealthConstants.java
Outdated
Show resolved
Hide resolved
...-idgenerator-service/src/main/java/io/mosip/kernel/idgenerator/constant/HealthConstants.java
Outdated
Show resolved
Hide resolved
added 2 commits
July 11, 2024 10:17
Signed-off-by: HimajaDhanyamraju2 <[email protected]>
Signed-off-by: HimajaDhanyamraju2 <[email protected]>
vishwa-vyom
requested changes
Jul 16, 2024
| @@ -84,7 +84,7 @@ public ResponseDto sendEmail(String[] mailTo, String[] mailCc, String mailSubjec | |||
| } | |||
|
|
|||
| @Async | |||
| private void send(String[] mailTo, String[] mailCc, String mailSubject, String mailContent, | |||
| public void send(String[] mailTo, String[] mailCc, String mailSubject, String mailContent, | |||
There was a problem hiding this comment.
why did we change this to public ?
There was a problem hiding this comment.
It was mentioned that @async annotated methods must be public. Please check this sonar rule - https://sonarcloud.io/organizations/mosip/rules?open=java%3AS2230&rule_key=java%3AS2230
| * @since 1.0.0 | ||
| * | ||
| */ | ||
| public class HibernatePersistenceConstant { |
There was a problem hiding this comment.
We cannot delete files since we are in LTS, confirmed on this to this to Sasi also
There was a problem hiding this comment.
We can mark it deprecated, but we cannot delete the files.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed vulnerabilities, reliability issues and removed some duplications