Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

heartbeat topic is in publish event #244

Closed
gnought opened this issue Jul 1, 2019 · 2 comments
Closed

heartbeat topic is in publish event #244

gnought opened this issue Jul 1, 2019 · 2 comments
Labels

Comments

@gnought
Copy link
Collaborator

gnought commented Jul 1, 2019

Caught '$SYS/' + that.id + '/heartbeat' topic on publish event, is it a design?

the packet is as follows when client is null:

 message from client  null Packet {
  cmd: 'publish',
  brokerId: 'tHMNcxXrm',
  brokerCounter: 1,
  topic: '$SYS/tHMNcxXrm/heartbeat',
  payload: <Buffer 74 48 4d 4e 63 78 58 72 6d>,
  qos: 0,
  retain: false,
  messageId: 0 }

Seems related to #7 and 9bca79c, but they do not mention what the packet is when client is null on publish event.

If it is not a design, I could submit a PR not to publish the heartbeat on the publish event.

@mcollina
Copy link
Collaborator

mcollina commented Jul 1, 2019

This is by design. It's a published packet, so it ends up in the publish event. client is null, because there is no client. It would be fantastic if you could update the docs.

@gnought gnought closed this as completed Jul 2, 2019
@gnought
Copy link
Collaborator Author

gnought commented Aug 17, 2019

Updated README.me in PR #245

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants