Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

restore series (instead of parallel) in SUBSCRIBE #133

Closed
mcollina opened this issue Jul 20, 2017 · 2 comments
Closed

restore series (instead of parallel) in SUBSCRIBE #133

mcollina opened this issue Jul 20, 2017 · 2 comments

Comments

@mcollina
Copy link
Collaborator

After #120, we can have an unordered granted array.
https://github.com/mcollina/aedes/blob/master/lib/handlers/subscribe.js#L63-L82 needs to be updated.

@behrad can you fire a PR for that?

@behrad
Copy link
Collaborator

behrad commented Jul 21, 2017

we can have an unordered granted array

Are you meaning that: Should the response granted array be ordered?
Why not to reorder them based on input subs array, when parallel is complete? instead of restoring to series?

@behrad
Copy link
Collaborator

behrad commented Jul 21, 2017

Can you first add a failing test?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants