Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

No topic checking - and crash #132

Closed
ckrey opened this issue Jul 18, 2017 · 0 comments
Closed

No topic checking - and crash #132

ckrey opened this issue Jul 18, 2017 · 0 comments

Comments

@ckrey
Copy link

ckrey commented Jul 18, 2017

aedes allows using wildcards in PUBLISH:

  • base/#
  • base/+/sub

aedes allows using illegal wildcards in SUBSCRIBE and UNSUBSCRIBE:

  • base/#/sub (multilevel wildcard not last element)
  • base/#sub (wildcard not alone)
  • base/+xyz/sub (wildcard not alone)

aedes does not check for empty (zero length) topics:

  • in PUBLISH, aedes silently interrupts outgoing client connections (SUBSCRIBE to '#' in client A, send PUBLISH 'empty' from client B, connection to client A dies)
  • in SUBSCRIBE aedes crashes
assert.js:60
  throw new errors.AssertionError({
  ^

AssertionError [ERR_ASSERTION]: '' == true
    at MQEmitter.on (/Users/ckrey/node_modules/mqemitter/mqemitter.js:74:3)
    at Aedes.subscribe (/Users/ckrey/node_modules/aedes/aedes.js:241:11)
    at SubscribeState.subTopic (/Users/ckrey/node_modules/aedes/lib/handlers/subscribe.js:106:12)
    at work (/Users/ckrey/node_modules/fastfall/fall.js:105:23)
    at /Users/ckrey/node_modules/aedes/lib/handlers/subscribe.js:74:5
    at MemoryPersistence.addSubscriptions (/Users/ckrey/node_modules/aedes-persistence/persistence.js:112:3)
    at SubscribeState.storeSubscriptions (/Users/ckrey/node_modules/aedes/lib/handlers/subscribe.js:73:9)
    at work (/Users/ckrey/node_modules/fastfall/fall.js:105:23)
    at Aedes.defaultAuthorizeSubscribe [as authorizeSubscribe] (/Users/ckrey/node_modules/aedes/aedes.js:306:3)
    at SubscribeState.authorize (/Users/ckrey/node_modules/aedes/lib/handlers/subscribe.js:39:17)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant