-
Notifications
You must be signed in to change notification settings - Fork 420
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixes mis specified dependency #1919
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Will wait for non-GPU tests to pass before merging
Red button merging as GPU workflow will continue to fail. This PR updates workflow to pip install after checking out branch, which means it will correctly use the right setup.py in future. However, |
What does this PR do?
Fixes a mis specified dependency that results in installation from source failing with
'extras_require' must be a dictionary whose values are strings or lists of strings containing valid project/version requirement specifiers
. Is likely related to the latest release of setuptools (https://setuptools.pypa.io/en/latest/history.html#v67-0-0), but I'm not sure what the dependency path is that leads us there, as this fails without changing anything about the environment it is running in (i.e. did not upgrade any packages, and setuptools is pinned to0.59.5
in the environment i'm running in).isort also broke so requires an upgrade: PyCQA/isort#2078
This also requires moving the pip install out of the mcli integration, so that it can pick up changes to setup.py before installing.
What issue(s) does this change relate to?
Closes CO-1701
Before submitting
pre-commit
on your change? (see thepre-commit
section of prerequisites)