Speed up comparison of environments #44
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
July 12, 2016 16:42
This version does not implement the Foldable/Traversable in Prelude proposal thus `elem` does not work on Sets.
This speeds up the comparison of environments in the common case of identical declarations.
|
Looks good to me. |
|
I did some benchmarks and it makes things a lot faster. The only drawback is the problem with nested mutual blocks. However we never use this and I can add a comment saying that it is not supported (and maybe make the resolver not crash but print an error message). If we ever need nested mutuals we can either revert these changes or come up with something that works. Does this sound good? Unless someone objects I'll merge this soon. |
This was referenced Jul 29, 2016
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When comparing environments, the declarations are unnecessarily compared, as they almost always come from the same source code (cf. #38). This pull request removes these unnecessary comparisons by annotating the declarations with their location in the code and comparing these first.
Note that the implementation can become unsound if nested
mutualblock are allowed (currently,resolveNonMutualDeclwill just crash).Also fixes one unrelated regression:
cubicalno longer builds on GHC 7.8.