Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding support to stacked bars #120

Merged
merged 3 commits into from
Dec 2, 2012
Merged

Adding support to stacked bars #120

merged 3 commits into from
Dec 2, 2012

Conversation

dynaum
Copy link

@dynaum dynaum commented Nov 20, 2012

I just modified the bar graph to render bars stacked.

@brunograsselli
Copy link

👍

@tiraeth
Copy link
Contributor

tiraeth commented Nov 24, 2012

LGTM. Please prepare a separete example file and revert bar.html to the original one. This will allow Olly to merge changes with one click :-)

@dynaum
Copy link
Author

dynaum commented Nov 26, 2012

Done!

@oesmith
Copy link
Contributor

oesmith commented Dec 2, 2012

LGTM! 👍

oesmith added a commit that referenced this pull request Dec 2, 2012
Adding support to stacked bars
@oesmith oesmith merged commit 691bd8d into morrisjs:master Dec 2, 2012
@gamov
Copy link

gamov commented Dec 17, 2012

This is great but I feel the following improvements are needed:

  • in the label there should be a total value displayed (of all the series)
    For Bar in general:
  • an option to display the value below the top of the bar segment.

eg: http://www.htmldrive.net/items/show/754/Beautiful-CSS-Stack-Bar-Graphs

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants